xmcnulty / wsb-trendies Goto Github PK

When the user updates the list of trending stocks, update the reddit comments

Room repository will act as single source of truth for this data. Implement use cases and repository functions for fetching data from remote API, storing, updating and fetching locally.

Add this indicator to the overview section of the screen.

Create a use case to return the hourly candles for a one week period

Once chart data is implement, draw data in chart area on detailed stock screen.

Create a Readme for this project/app

Improve use of loading progress indicators and snackbars for loading and error states.

It appears the tradestie API mistakes some strings in comments for tickers when they are not. Which leads to a NullPointerException being thrown:

"Parameter specified as non-null is null: method kotlin.jvm.internal.Intrinsics.checkNotNullParameter, parameter ticker"

This occurs when mapping the DTO to a StockOverview object because there was no data returned ... the stock doesn't actually exist.
Need to figure out a way to handle this.

CodeFactor found an issue: The class or object WsbApplication is empty.

It's currently on:
app\src\main\java\io\xavier\topwsb\WsbApplication.kt:7

Fetch reddit comments for a stock that is trending on WSB using remote, api. Store in Room db for fetching.

C:\Users\xmcnu\StudioProjects\top-wsb-tickers-android\app\build\tmp\kapt3\stubs\debug\io\xavier\topwsb\domain\model\WsbComment.java:20: warning: ticker_trending_stock column references a foreign key but it is not part of an index. This may trigger full table scans whenever parent table is modified so you are highly advised to create an index that covers this column.

@Entity( tableName = TABLE_NAME_COMMENTS, foreignKeys = [ForeignKey( entity = TrendingStockEntity::class, parentColumns = arrayOf(TICKER_STOCK_COL_NAME), childColumns = arrayOf(TICKER_STOCK_COL_NAME), onDelete = CASCADE )] ) data class WsbComment( @PrimaryKey(autoGenerate = true) @ColumnInfo(name = "comment_id") val id: Int, @ColumnInfo(name = TICKER_STOCK_COL_NAME) val ticker: String, val text: String, val createdUtc: Long, val author: String, val link: String )

Implement fetching of chart data from remote api. Data will be stored in Room database as single source of truth.

Starting with one week time frame, create a formatter for x-axis values.

When loading from cache of trending loading stocks. The stock type for "Common Share" stocks is Unknown.

When data is returned from the tradestie api, store it in a room database. When loading from the data first check the room database and update with new data from the api if necessary.

CodeFactor found an issue: This comment contains 'TODO:' that has been defined as forbidden in detekt.

It's currently on:
app\src\main\java\io\xavier\topwsb\presentation\stock_detail\StockDetailScreen.kt:175
Commit 4d7e3e8

Because this app shows comments for a trending stock in a day- change the price chart to display the intraday data for that day. In the case of a weekend or banking holiday, show the chart for the last trading day.

When running the app and selecting "EV" from the list, the below NullPointerException is thrown. It appears the Dto returned from the repository is null. It is unclear if it is null because the body of the response from the API is empty or if there is an issue with Gson parsing.

java.lang.NullPointerException: Attempt to invoke interface method 'java.util.Set java.util.Map.entrySet()' on a null object reference
at io.xavier.topwsb.domain.mapper.IntradayDataMapperKt.toIntradayData(IntradayDataMapper.kt:55)
at io.xavier.topwsb.data.repository.IntradayDataRepositoryImpl.getIntradayData(IntradayDataRepositoryImpl.kt:19)
at io.xavier.topwsb.data.repository.IntradayDataRepositoryImpl$getIntradayData$1.invokeSuspend(Unknown Source:15)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
at android.os.Handler.handleCallback(Handler.java:942)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loopOnce(Looper.java:201)
at android.os.Looper.loop(Looper.java:288)
at android.app.ActivityThread.main(ActivityThread.java:7898)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [StandaloneCoroutine{Cancelling}@7e68393, Dispatchers.Main.immediate]

Separate getTrendingStocks and refreshCache in the repository implementation. This is a better practice. If the cache is empty when calling getTrendingStocks, refreshCache will be called from getTrendingStocks, loading which will populate the cache. getTrendingStocks will always return from the cache. Additionally, a new use case will be needed for refreshing the data that is displayed to the user. Ex.

getTrendingStocks
`
if(stocks.isNotEmpty() {
return stocks
}

refreshCache()

return dao.getTrendingStocks() `

refreshCache

` dao.clearAll()

val stocks = api.getTrendingStocks()

dao.insertAll(stocks) `