The geoip from xp-forge

geoip's People

Contributors

Watchers

geoip's Issues

Unittests should use fixture DB

Currently, all tests are skipped if no GeoLite2-City.mmdb file exists.

Option 1: Download GeoIP fixture in Travis (not nice on MaxMind's bandwith)
Option 2: Commit small fixture database (but where to get from)?

Error message when input is not an IP address

This could be more precise as to what's going wrong:

$ xp -w '\com\maxmind\geoip\GeoIpDatabase::open(...)->lookup($argv[1])' not.an.ip
Uncaught exception: Exception lang.reflect.TargetInvocationException (xp\runtime\Dump::main)
  at <main>::inet_pton() [line 191 of Input.class.php] inet_pton(): Unrecognized address not.an.ip
  at lang.reflect.Method::invoke(NULL, array[1]) [line 259 of class-main.php]
Caused by Exception lang.IllegalStateException (Should not arrive here)
  at <main>::inet_pton() [line 191 of Input.class.php] inet_pton(): Unrecognized address not.an.ip
  at com.maxmind.geoip.Input::offsetOf((0x9)'not.an.ip') [line 28 of Reader.class.php]
  at com.maxmind.geoip.Reader::lookup((0x9)'not.an.ip') [line 1 of Dump.class.php(45) : eval()'d code]
  at <main>::eval() [line 45 of Dump.class.php]
  at xp.runtime.Dump::main(array[3]) [line 0 of StackTraceElement.class.php]
  ... 2 more