The tableAttributeFrom function in rdbms.mysqli.MySQLiDBAdapter enforces the Type of a record to have a length. For example the type text does not have this field, so it fails with

Uncaught exception: Exception lang.IndexOutOfBoundsException (Undefined offset: 3)
  at <main>::__error(8, (0x13)'Undefined offset: 3', (0x69)'/home/idev/dev/temp/codegen/vendor/xp-framework/rdbms/src/main/p', 108, array[2]) [line 108 of MySQLiDBAdapter.class.php]

In the MySQL implementation this is fixed with a default value

  public static function tableAttributeFrom($record) {
    preg_match('#^([a-z]+)(\(([0-9,]+)\))?#', $record['Type'], $regs);
    return new DBTableAttribute(
      $record['Field'],                                         // name
      self::$map[$regs[1]],                                     // type
      false !== strpos($record['Extra'], 'auto_increment'),     // identity
      !(empty($record['Null']) || ('NO' == $record['Null'])),   // nullable
      (int)(isset($regs[3]) ? $regs[3] : 0),                    // length
      0,                                                        // precision
      0                                                         // scale
    );
  }

Use Traversable, see https://wiki.php.net/rfc/internal_method_return_types

• Fatal error: Unable to open database: unable to open database file - see https://travis-ci.org/xp-framework/rdbms/jobs/63626399
• Fatal error: Declaration of rdbms\criterion\SimpleProjection::asSql() must be compatible with that of rdbms\SQLRenderable::asSql() in /home/travis/build/xp-framework/rdbms/src/main/php/rdbms/criterion/SimpleProjection.class.php on line 14 - see https://travis-ci.org/xp-framework/rdbms/jobs/64997716
• unittest.AssertionFailedError{ expected [lang.types.Bytes(8)@{UAXNPP\O}] but was [lang.types.Bytes(8)@{@@@@@@@@}] using: 'equals' } in rdbms.unittest.mysql.MySqlPasswordTest::protocol40

[line 66 of .\vendor\xp-framework\rdbms\src\main\php\rdbms\DBConnection.class.php]

PHP 8.0+

Idea

Implementation

See https://gist.github.com/thekid/ae35fc4555252938dcea43cf135b5adf

https://wiki.php.net/rfc/sqlite3_exceptions

The connection should be reset when packet no. out of order as the connection is unusable!

Reproduce

1. Open connection (e.g. using ISQL)
2. Restart MariaDB server (using kill will not do the job!)
3. Wait, then issue a query: *** Exception rdbms.SQLStatementFailedException (errorcode -1: Packet no. out of order, have 0, expecting 1
4. Issue another query: *** Exception rdbms.SQLStatementFailedException (errorcode -1: Packet no. out of order, have 35, expecting 1)
5. etcetera...

See https://travis-ci.org/xp-framework/rdbms/jobs/135264912:

F unittest.TestWarning(test= rdbms.unittest.integration.MySQLIntegrationTest::connectFailedThrowsException, time= 0.134 seconds) {
  [""mysql_connect(): Access denied for user 'wrong-user'@'localhost' (using password: YES)" in mysqli::hh_real_connect() (, line 0, occured once)"]
 }

×: 45/104 run (59 skipped), 44 succeeded, 1 failed
Memory used: 2048.00 kB (2048.00 kB peak)
Time taken: 5.856 seconds

This this() core functionality was removed in XP 6.6.0

When creating dataset classes with the framework's generator the primary keys doesn't get detected for postgresql databases. Therefore no getBy() methods are created and after saving a new row the value of the auto increment column remains unset in the object.

The rdbms.unittest.mock package has been picked by several of our libraries to emulate certain result sets.

With the current location with the mock package being within src/test, a library cannot pick it any more. Should we expose it to src/main, possibly as rdbms.mock package?

• MySQL, PostgreSQL and SQLite3 on Travis-CI, see https://docs.travis-ci.com/user/database-setup/.
• MSSQL cannot be tested there as I do not know any way of getting either server running inside Travis-CI - instead, use https://www.appveyor.com/ (see here for an example)

In commit 1101dca, all of the sqlite package was removed in favor of the sqlite3 package. That package, however, does not have an SQLiteDBAdapter, so we cannot do reflection on these kinds of databases any more.

Furthermore, we're now having an unresolved dependency in xp.codegen.dataset.Generator.

I suggest to extract the removed class from the referenced commit and add it to the sqlite3 package.