Giter VIP home page Giter VIP logo

customizeanimals's People

Contributors

xt-0xff avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar

customizeanimals's Issues

Bug: ContentFinder patch seems to be applying to more than expected

Hi there! It appears your patch here is patching more than expected. Music-Expanded/music-expanded-framework#45

Steps to Replicate

Load CustomizeAnimals + Music Expanded Core + Music Expanded Framework, this should cause the error to pop up on load.

Thoughts

So in MEF when a theme is selected, and when the menu loads, we call ResolveReferences on SoundDefs to reload audio grains (for themes that switch sounds around). Normally this happens before mod loading I suppose, so that explains why you may've not noticed it happen for any of the vanilla sounddefs.

I figure the intent here is that textures get loaded when a thing spawns, and so the patch catches it, but it assumes all things that the patch handles are Texture2Ds.

I'm really not sure how to solve for this one ๐Ÿค” If you've got an idea of how I could swap out sounds without Resolving References I could do that, but I think a better approach would be to limit this patch.

Stacktrace

Could not load UnityEngine.Texture2D at MusicExpanded/Medieval/Medieval_Fantasy_Quest_Complete in any active mod or in base resources.
UnityEngine.StackTraceUtility:ExtractStackTrace ()
Verse.Log:Error (string)
(wrapper dynamic-method) Verse.ContentFinder`1<UnityEngine.Texture2D>:Verse.ContentFinder`1[[UnityEngine.Texture2D, UnityEngine.CoreModule, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null]].Get_Patch1 (string,bool)
Verse.Sound.AudioGrain_Clip/<GetResolvedGrains>d__1:MoveNext ()
Verse.Sound.SubSoundDef:<ResolveReferences>b__33_0 ()
Verse.LongEventHandler:ExecuteToExecuteWhenFinished ()
Verse.LongEventHandler:ExecuteWhenFinished (System.Action)
Verse.Sound.SubSoundDef:ResolveReferences ()
Verse.SoundDef:ResolveReferences ()
MusicExpanded.ThemeDef:ResolveSounds (MusicExpanded.ThemeDef)
MusicExpanded.Patches.MusicManagerEntry/StartPlaying:Prefix (RimWorld.MusicManagerEntry)
(wrapper dynamic-method) RimWorld.MusicManagerEntry:RimWorld.MusicManagerEntry.StartPlaying_Patch1 (RimWorld.MusicManagerEntry)
RimWorld.MusicManagerEntry:MusicManagerEntryUpdate ()
Verse.Root_Entry:Update ()

Doesn't work in 1.4

Understandably, this mod is broken with the release of 1.4. Are there any plans to update? This is one of my favorite mods, and while I can play without it, being able to edit anything about any animal sure makes games more fun.

If you need logs or whatever I can get 'em.

can't allow edited animals into pens

if I add roaming interval to any animal that doesn't have it, that animal won't appear in pen animals filter list, so I can't put it into a pen. I have to restart the game for pen animal list to update. Maybe you could force that list to update each time roaming interval is added to an animal?

some animal from MorrowRim trolls mod causes error (probably cave troll which appears only when VAE Caves is installed)

https://gist.github.com/HugsLibRecordKeeper/d26414afb74309e68f9becfad3a8a0cb
the error that I am getting doesn't display into the log so
image
this happens when I was clicking through trolls in the mod. I didn't notice on which troll it crashed the mod settings window but I think it is on cave troll which only appears with VAE Caves installed, because it also had a problem where some other mods couldn't customize it, and the mod that shows what mod this is from doesn't display what modt he cave troll is from.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.