xxue / assignment_1 Goto Github PK

Question 1

This solution works! Although the intent with the titleize method was to take a string as an argument, instead of from user input. So something like:

def titleize(string)
  # ...
end

gets.chomp works great when your user is running the code in their terminal, but most of the time the methods you write will be used by other methods, so you can't get user input directly.

Question 2

Very good code organization! Indenting is key to readable code 😄

Same comment as question 1, though. User input shouldn't be used to pass values to classes. Instead, you can initialize the class like this:

class Book
  # ...

  def initialize(title: "", chapters: "")
    # ..
  end

Question 3

We looked at this in class 👍

Question 4

Nice and concise!

One small note: it's good practice to name block variables clearly, the one exception being if the thing is just a number. For instance:

major_cities.each do |province, cities|
  # ..
end