xxue / quiz_1 Goto Github PK

Good job! Most of the functionality and layout elements are there. Right now you're sitting at 80% - if you can make the dashboard work on mobile then it'll be 💯% 😁

I really like how you used an array for the "trending" tweets instead of hardcoding them into the view. This decouples the data from the display, which would allow you to calculate the trending topics in a different way without changing your layout code.

You're calculating a date in the get function, but ideally you would calculate the date that each was posted and store it in the cookie alongside the username and text.

Additionally, the way you're passing req.cookies to the view means that you may get some unexpected data. Cookies are managed on a domain basis, meaning that over time you'll build up a bunch of different cookies for localhost for the various applications you're working on. Iterating over req.cookies will inadvertently display data that aren't actually tweets!

A better approach would be to create a tweets key:

// storing a tweet
let tweet = req.body;
res.cookie('tweets', tweet, { maxAge: 2592000000 })

// retrieving all the tweets
let cookies = request.cookies.tweets