Giter VIP home page Giter VIP logo

babel-plugin-transform-jsx-url's People

Contributors

dependabot[bot] avatar xyyjk avatar

Stargazers

 avatar

Watchers

 avatar

Forkers

pytechmike

babel-plugin-transform-jsx-url's Issues

Handle ES default exports

If loader returns ES module then this plugin fails. This happens for example with @svgr/webpack which in conjuction with file-loader returns

export default 'url'
export const ReactComponent = {}

This is done for tree shaking. Otherwise React component implementation will be attached to every image component.

So I think this plugin may do something like require('path').default || require('path'). Don't see any shorter variant to require universal module

Fails on relative paths

Relative paths are incorrectly resolved to the current file. Seems like they are not joined correctly but just concatenated as is with root (if defined in config). This JSX expression should work, but it doesn't

<img src="./images/logo-jsx.svg" alt="" />

Error

Module not found: Error: Can't resolve 'C:\Users\const\Desktop\react\src./images/logo-jsx.svg' in 'C:\Users\const\Desktop\react\src'

DataURIs should not be processed

JSX expressions with base64 encoded images should not be processed by this plugin. Currently it produces corrupted image paths on images like this

<img src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgA
			AAAoAAAAKCAYAAACNMs+9AAAABmJLR0QA/wD/AP+gvaeTAAAAB3RJ
			TUUH1ggDCwMADQ4NnwAAAFVJREFUGJWNkMEJADEIBEcbSDkXUnfSg
			nBVeZ8LSAjiwjyEQXSFEIcHGP9oAi+H0Bymgx9MhxbFdZE2a0s9kT
			Zdw01ZhhYkABSwgmf1Z6r1SNyfFf4BZ+ZUExcNUQUAAAAASUVORK5
			CYII=" alt="" />

data: protocol URLs should be ignored as well as http: and https:

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.