y-less / fixes-plugin Goto Github PK

Hey, we talked about this before. Is there the ability to use it directly in a sampGDK gamemode ? We should be able to just paste some source files in our gamemode's files and run correctly while only including a header for the declarations. I see that you are also using the log core plugin, which adds an additional dependency for the server (logcore.so in the same folder as samp-server). When I had to use MySQL in the sampGDK gamemode the most problems it had with the logcore plugin, because it used way too many AMX functions inside which were buggy with a sampGDK plugin, the server was crashing (if I remember correctly, or memory leaking A LOT) when any kind of debugging was enabled.

This is necessary for custom functions and old bad functions added by this plugin, for the native functions that are just fixed I think that the AMX redirect would make its job if this plugin is loaded before the server plugin.

It would be great if this would be possible easily. It should provide a Fixes namespace for every custom/native-hooked function and hooked callback.
For any sampGDK/sampSDK callback function we should have an even deeper namespace called Fixes::Internal or something like that, so we could put Fixes::Internal::Load under our Load function (of course, other necessary callbacks too). Not sure about all callbacks used in this plugin, we would have to add every single one of them under our callbacks, I don't have any easier idea about this right now. Adding all these tons of callbacks would be a pretty long setup. Maybe they could be hooked under OnPublicCall with string hashing (to make the comparations faster, with a switch) and just add Fixes::Internal::OnPublicCall under our OnPublicCall callback, but this would require pretty much more code in this plugin I think.

I wonder if Kalcor could give us a better and more direct interface for C/++ gamemode developing, the compatibility between sampGDK and other plugins really sucks right now. Pawn is terrible (but it actually has some advantages compared to C++ [and a lot more compared to C], can't remember exactly what advantages, but "0b" binary prefixing was one of them, but it was added in C++14).

If you can't make or don't want to add this I understand, it's pretty hard with all those hooks (as C++ doesn't have any hooking without memory addresses, probably because of security).

This whole fixing bugged things in a reliable way is quite a challenge. I have to thank you again for all you did for SA-MP.

Also, I see that you created one test fix: SetPlayerPos, which is in a .cpp with the name of the function. Wouldn't it be better if all fixes would be in a single file ? It would compile fast anyway. Or, at least, it should contain more fixes of one type in a file. Fixes that aren't requiring any other variable could be in a fixes/simple.cpp (bad name) file, while more complex ones like PassengerSeating should have their own files with all the hooking made there (hooking is harder with independent files).

Hi there, happy to see u again.

What is this plugin for? It is will be a new master version of all fixes which are all spread around the internet?