yackle / climageeditor Goto Github PK

Great class, thanks for sharing it :-)
Is there a way to hide some of the features in the bottom tool view without hacking the code? I use cocoapods and I would like to leave your code untouched

thanks
Paolo

Hello again.......
For helping you to understand and give me a solution.
The errors are the following....

Apple Mach-O Linker Error..

"OBJC_CLASS$_CIContext", referenced from:

"OBJC_CLASS$_CIFilter", referenced from:

"OBJC_CLASS$_CIImage", referenced from:

"OBJC_CLASS$_CIVector", referenced from:

"_kCIInputImageKey", referenced from:

"_vImageConvolve_ARGB8888", referenced from:

ld: symbol(s) not found for architecture i386
clang: error: linker command failed with exit code 1 (use -v to see invocation)

First of all, thank you for the fantastic library! It is exactly what I need for my Photo Manipulation and sharing application, and it sounds like their is a lot of great features that are being worked on.

I have fully implemented CLImageEditor into my target, and all of the tools and features work really well for me. However, when I select my edited image to return back to my storyboard, the new edited image takes up a very small portion of the screen, and is positioned to the left hand corner. I have compared my storyboard to the Demo app's, they both look very similar and I have not modified the image editor in any major way yet. I was simply inquiring if this is a possible and likely problem on my part on the storyboard implementation, or if the only way to resize the edited image is to use the scroll view.

Thanks again for the amazing library,
Christopher.

Does someone know how to add a pinch to zoom on image on edit mode to add stickers?

In bundle , we dont have way to include normal and @2x.png . If we want @2x its included too with normal. So both appears on the bottom bar.

Turn the photo to black and white. And then user can choose the area to restore the original color.

For Example, I want to change the icon of Rotate -> 90° icon or flip horizontal icon.
How can I do this?

May I know how to use the custom sticker path? I can't use that.

Hello,

Has anyone got any idea how to implement GPUImage [https://github.com/BradLarson/GPUImage] as an Optional ImageTool for more advanced image filters and manipulations. I've been trying for the last week to implement this feature, to little success.

Any response is greatly appreciated.

Christopher

If I run the app on iOS 6, it shows only 3 filters whereas it shows 14 filters on iOS 7. Can you please test and fix this?

Firstly thanks for your efforts.

I want to add my logo for branding my application like Retrica.

is it possible?

I am trying to achieve in having the sticker tool to composite my custom images to the edited image so that the sticker image merges with the multiply blend effect for the final result having more transparency to the sticker image thus a merged look, much like a tattoo or watermark.
I need to have the sticker image to contain some of the image below it show through in which the core image framework's blend filter multiply achieves, however I have no idea where to attach the code to or what code will best achieve this. Could you or some one point me to what and where I can call up the blend multiply filter for the stickers?
Thanks

Hi,

I tried to integrate this library with cocoapods by adding :

pod 'CLImageEditor'

or

pod 'CLImageEditor/AllTools'

in my Podfile but i always get the following error :
[!] Invalid Podfile file: /Users/florianbasso/Documents/Developpement/iOS/crossroad_ios/Podfile:4: syntax error, unexpected '', expecting end-of-input
pod 'CLImageEditor/AllTools’, '> 0.0'
^. Updating CocoaPods might fix the issue.

However when i paste in my Podfile : pod 'CLImageEditor', '~> 0.0'
It works the pod is installed but I have a lot of problem with methods undefined, etc...

Do you have any idea how to fix this please ?
Thanks and have a nice day :)

hi, i'm french so sorry for my bad english,

Your imageEditor is amazing, but i want to know how i can put a space between every item toolbar because for an application for my final school test i would like to use juste 3 item and that 3 item take all toolBar, so i need some space,

thank you very much,
merci beaucoup ciao

The following 2 lines of code fixed the issue for me in CLSplashTool.m:

_drawingView.contentMode = UIViewContentModeScaleAspectFit; // new line of code; below [[UIImageView alloc] initWithFrame...

_grayImage = [[self.editor.imageView.image aspectFit:CGSizeMake(_drawingView.width_2, _drawingView.height_2)] grayScaleImage]; // modified existing line of code; by changing resize to aspectFit

The back and ok button is not showing up in the demo app, when i use the the camera to edit a photo.

Hi

Does someone can help to find the better way to add iPad compatibility?

Touch and draw on the screen. Choose pencil of different color and thickness.

when it has been alloc CLTextTool, the memory become 19.3MB.It is a little big, but i can be tolerant of this.
when I type a lot of words , the memory become 200+MB, oh,that's terrible,my iphone6 become so slow and i can't type more words immediately.

here is the screenshots

somethings I missed? Or,some ways for solving this problem.
hope your feed back. thank you...

issue from an chinese IOSDev whose English is a little weak.

i'm looking for if you would like to release version without xib file ;)

Hello,
Many thanks for your excellent tool.
I have a small problem.
I try to attach your tool in an app I am implementing and I get an error.
Is something missing that I can not find?
Can you help please?

George N. Gerardis

For now, we can add a menu btn by creating child class of CLImageToolBase.
Is there any way to add a menu btn for example another sticker button with different name, icon and resources path?

Its very nice library you create but i having one issue with this when i add text smily sticker and setting in image then when i tap on Done button that main image still look same but i added sticker text getting Blur on image can you please help me on this.

Here I attach screenshot befor done click:

After done click

Hi,

does CLImageEditorDemo need some update to be full compatible with iPhone 6 / 6+ screens?

how to include CLTextTool alone to my project....?
help me..

If I make this Library work with iPad and Landscape Orientation, will you accept a merge request? I already have it part way there.. Image Editing, in general, is popular on the iPad.. It would be a shame to keep this Library limited to iPhone only.

Hi, This isn't actually an issue, but i'm struggling to find what sets the minimum size of the stickers?
When you use the circle to shrink them, they stop when they get to a certain size. Can they go smaller?

Thanks

Hi there, first of all love your work!! :) Is it possible to crop the image to a square image before editing?

Thank you for your answer.

an nice idea is to do implement a batch Conversion. On button press all the effects will be save in a batch. And this batch you can do on any image you want. Is this possible.

Kevin

Hi! I tried to use this editor in iOS 7 with only status bar hidden mode. And it looks like something is wrong in layout. So when main toolbar hides and effect's toolbar appears it appears a bit upper (64px) than in your demo app. Could you help me to fix this issue?

hi!

I'm trying to make an iPad version for my app, i don't find where i could make modification for slider in effects tools

Someone can help?

Using CLRotateTool to rotate an upsidedown image works well when looking at the image in xcode, but after saving to iphone image library the image is still upsidedown. Is there a metadata change in CLRotateTool that should be included when saving the image?

After modifications apply in Bloom or Gloom effects the save image is resize? Is it normal, seems the same filters use in another app done the same bug!

Spot effect don't apply modifications after changes!

I found that last modifications in CLImageEditor/Utils/UIImage+Utility.m made the bugs! Any comment?

• UIGraphicsBeginImageContext(image.size);
• UIGraphicsBeginImageContextWithOptions(image.size, NO, 0.0);
• UIGraphicsBeginImageContext(CGSizeMake(rect.size.width, rect.size.height));
• UIGraphicsBeginImageContextWithOptions(CGSizeMake(rect.size.width, rect.size.height), NO, 0.0);

I think the way the code is written is absolutely brilliant . Only thing i see missing now is frames around the picture to complete it. I will try doing it too.

I notice that when i use a photo piked with camera in iPhone 4 and trying to apply filter the memory start rising and, at the end, crash the app. The filter never appear in preview images. I suppose that this happen in this (slow) device because is too slow to apply filters to big images and, at the end, the app crash.

On iPhone 5s everything is ok, obviously.

PS: sorry for my english :)

The code below will crop the transparent space around the image after the pixellate effect is applied to it. Without this code the user sees a white border around the image when they close the editor. I hope this helps someone out. It could probably be cleaned up a bit, but it's working just fine for me.

This change needs to be applied to the file CLImageEditor/ImageTools/CLEffectTool/CLEffect/CLPixellateEffect.m
Find -(UIImage_)applyEffect:(UIImage_)image { ..... } and replace it with..

- (UIImage*)applyEffect:(UIImage*)image
{
    CIImage *ciImage = [[CIImage alloc] initWithImage:image];
    CIFilter *filter = [CIFilter filterWithName:@"CIPixellate" keysAndValues:kCIInputImageKey, ciImage, nil];

    //NSLog(@"%@", [filter attributes]);

    [filter setDefaults];

    CGFloat R = (0.1 * _radiusSlider.value) * MIN(image.size.width, image.size.height);
    CIVector *vct = [[CIVector alloc] initWithX:image.size.width/2 Y:image.size.height/2];
    [filter setValue:vct forKey:@"inputCenter"];
    [filter setValue:[NSNumber numberWithFloat:R] forKey:@"inputScale"];

    CIContext *context = [CIContext contextWithOptions:nil];
    CIImage *outputImage = [filter outputImage];

    CGImageRef cgImage = [context createCGImage:outputImage fromRect:[outputImage extent]];

    UIImage *result = [UIImage imageWithCGImage:cgImage];

    CGImageRelease(cgImage);

    CGImageRef inImage = result.CGImage;
    CFDataRef m_DataRef;
    m_DataRef = CGDataProviderCopyData(CGImageGetDataProvider(inImage));
    UInt8 * m_PixelBuf = (UInt8 *) CFDataGetBytePtr(m_DataRef);

    int width = result.size.width;
    int height = result.size.height;

    CGPoint top,left,right,bottom;

    BOOL breakOut = NO;
    for (int x = 0;breakOut==NO && x < width; x++) {
        for (int y = 0; y < height; y++) {
            int loc = x + (y * width);
            loc *= 4;
            if (m_PixelBuf[loc + 3] != 0) {
                left = CGPointMake(x, y);
                breakOut = YES;
                break;
            }
        }
    }

    breakOut = NO;
    for (int y = 0;breakOut==NO && y < height; y++) {

        for (int x = 0; x < width; x++) {

            int loc = x + (y * width);
            loc *= 4;
            if (m_PixelBuf[loc + 3] != 0) {
                top = CGPointMake(x, y);
                breakOut = YES;
                break;
            }

        }
    }

    breakOut = NO;
    for (int y = height-1;breakOut==NO && y >= 0; y--) {

        for (int x = width-1; x >= 0; x--) {

            int loc = x + (y * width);
            loc *= 4;
            if (m_PixelBuf[loc + 3] != 0) {
                bottom = CGPointMake(x, y);
                breakOut = YES;
                break;
            }

        }
    }

    breakOut = NO;
    for (int x = width-1;breakOut==NO && x >= 0; x--) {

        for (int y = height-1; y >= 0; y--) {

            int loc = x + (y * width);
            loc *= 4;
            if (m_PixelBuf[loc + 3] != 0) {
                right = CGPointMake(x, y);
                breakOut = YES;
                break;
            }

        }
    }


    CGRect cropRect = CGRectMake(left.x, top.y, right.x - left.x, bottom.y - top.y);

    UIGraphicsBeginImageContextWithOptions( cropRect.size,
                                           NO,
                                           0.);
    [result drawAtPoint:CGPointMake(-cropRect.origin.x, -cropRect.origin.y)
           blendMode:kCGBlendModeCopy
               alpha:1.];
    UIImage *croppedImage = UIGraphicsGetImageFromCurrentImageContext();
    UIGraphicsEndImageContext();

    CFRelease(m_DataRef);
    return croppedImage;
}

Hi,

I want to add customs filters (ex: add Image with transparency to create more effects) does CLFilterTool a good starting point? ( I'm newbie :) )

Hi yackle,
could you add customizing for the clipping tool?

I would like to force my users to crop their photo to one of the specified sizes defined in the ratios key of CLClippingTool's optionalInfo dictionary.

What the best way of going around this? Should I make a custom subtool that based off of CLClippingTool?

Is there any way to prevent the user from selecting done from a subtool?

Hi!

Is it possible to enable rotation for landscape mode, and how can i create custom filters?

I have 15-20 large resolution stickers (which I am using as frame images, not actual stickers) of resolution 1024px~ and 300-900kb each
In simulator clicking the sticker button had a delay of 2 secs before the sticker tool opened, but in a actual ipad air there was a 6-7 secs delay

So, what slows down the stickers tool load time ? Size of images, resolution or number of images ?
Is there any way to improve it like pre-loading them, async load or perhaps showing a activity indicator that the app is busy loading them ?

1. Is it possible to disable some image editing options I dont want to use or rather load the options I want to use ? Lets say I don't want advanced options like curves etc. is it done by tool.available = NO; example in readme ?
2. Any possibility to load and edit multiple images at once ? Something like a collage or such, like add 2 images and edit them together, there should be some possibility since you can add multiple emoticons or frames/stickers. I had a workaround idea of possibily adding a duplicate tool option based on stickers and load images from album to it to add additional images like stickers, but that won't be a clean thing over main image

This is excellent. Thank you for making this.
I was looking for something just like Aviary but open source and finally you have started it.

I'm sure you have a roadmap/todo list but just wanted to suggest that adding of text and stickers to images would put this on par with Aviary.

Thanks again

Is it possible to create another (3rd tool) based on stickers or emoticons which loads a diff set of images ?
I want this 3rd tool to load images from user's album, as part of my attempt to do multi image editing while using main image as a white canvas

Hello. If I need a full screen menu for the stickers menu, which part of the code I should modify?

CLImageEditorDemo crash under iOS 8 on iPad when save btn pressed, i know it's UIActivityViewController causing the crash but i don't know how i can fixe it

First, thx for the great work!
Was just wondering which approach would you suggest in order to keep a reference to the original image once filters are applied (and other effects), in order to rollback.

For instance, when a filter is applied and confirmed the original image is modified and if I m not wrong, the original image cannot be displayed again. Same for the other effects.

Thx for your help.

What is the way to get same image size main screen and edit screen?
resetImageViewFrame in _CLImageEditorViewController is different than resetImageViewFrame in ViewController demo, so i would like same size for both views

Image in main screen don't look same in main screen under iOS7 and iOS8, need some help please
(in CLImageEditorDemo)

If device in landscape mode and i press edit button window becomes white and image not showing

But in portrait mode everything is fine.

How fix this bug?
Thanks you.

When set color for Text. If you scroll down alpha column, all control for set color not response. I attach image for this issue. :)