Please support for macOS Catalina, thanks a lot !

I am on Linux and if I read the last comic in the list, it doesn't show up as read after I am done with it.
If I stop on the second to last page and close yacreader, the page shows up in the overview. If I then reopen it and read the last page and close it, it is still on the second to last page.
If I can help with anything, please let me know.

ps: Everything is local, I don't read anything over the network.

When you mark a folder as read/unread it should mark all the comics in the folder as read/unread.
Currently marking the folder as read/unread does nothing, you still need to manually mark all the comics as read/unread

YACReader currently uses qmake as build system, but this is showing its limits. We really need some proper dependency management, modularization and generally could use some improvements to reduce our build time and better handle our build targets.
While some of this probably could be done using qmake many 'advanced' Qt projects already use CMake for this purpose and even Qt upstream is slowly deprecating qmake in favor of it.

As this will mean that we'll be more or less rewriting our whole build system I propose to slowly introduce the new build system alongside our old build process and to start with the library server, as its build process will benefit the most from having better dependency detection and its code footprint is lower than the reader and the library targets.

OPDS is an XML-based standard for exposing ebook libraries to readers.
It basically allows a reader to browse an online catalog and download the stuff he wants to read off the server instantly.

It's implemented by a few servers for comics/ebooks, namely Calibre, Ubooquity and LANraragi.

OPDS as a source is implemented by a number of mobile readers, but the desktop offerings are limited to say the least, even more so on Linux/macOS.

Since YACReader has support for multiple libraries already, being able to add OPDS catalogs would be a fitting/convenient feature to avoid duplication of metadata/downloading comics manually.
I realize YACReaderLibrary is already a server for the mobile versions, so this might not interest you at all. 😅

I've been trying to build the windows executables in order to start assisting the development, but for the life of me I can't get it to make. I'm trying to build it on cygwin with the mingw64 64bit toolchain for qt5 and have managed to get the pri files to work with it (added extra unix:cygwin... steps which mirror the win32 steps) but when trying to run the makefile it throws out an error "expected unqualified-id before string constant", it doesn't give a line number, source file or any other helpful detail I could use to diagnose the issue.

If anyone else has run into this problem or know where the issue might be that would be really appreciated. My fork has the pri changes if you would like to review those.

OS: MacOS Mojave 10.14.5
YacReader version: 9.6.2

Option to hide toolbar is not present resulting in an always present toolbar hampering the experience of reading.

On the make install step:

/usr/lib64/qt5/bin/qmake -install qinstall -exe /builddir/build/BUILD/yacreader-9.6.0/YACReader/YACReader /builddir/build/BUILDROOT/yacreader-9.6.0-1.fc30.x86_64/usr/bin/YACReader
cp ../README.txt ../README
cp: cannot stat '../README.txt': No such file or directory

Seems like README.txt now README.md.

In keyboard shortcuts > Reading, you can find Move up, Move down, Move left, and Move up.

Whether or not they are configured, they are always mapped to arrow keys.
I cannot set them to other keys.

I'm using the latest version of YACReader (9.5) on Mac OS (Mojave 10.14.2). I'm using just the standalone reader. I have a few of features or changes that I'd like to suggest.

1. Add an option to to disable automatic bookmarks.
I personally dislike this feature, and have disabled it via locking the "bookmarks.yacr" file to be read only. I just don't find it very useful, and it's mildly annoying when I open something I had skimmed earlier. It also conflicts with the 'open next issue' feature. When I turn passed the last/first page it would open the next issue at the page where the bookmark had been set for it, which obviously isn't ideal.

2. Add an option to disable automatically opening the next issue.
This is also a person dislike, it's a minor thing. I just like to get to the end of an issue, and then for the page turning to stop.

3. Add a scroll bar to the window so you can see where on the page you are.
Currently I cannot tell were I am on the page, a scroll bar would fix that. It's a convenience thing. It also causes issues with scrolling page turning, as you scroll to see the bottom of a page but end up on the next one as you don't know if the panel ends at the bottom of the page, or if there's more to see.

4. Add an option to disable automatic page turning via scrolling.
This is coupled to the above, but I also dislike it. I prefer to be able to freely scroll on a page without the risk of accidentally jumping to another page. I'd prefer there to be a click zone at the side of the page to turn to the next one instead, but just being able to disable it would be great.
It also doesn't work with some scrolling settings. My scroll is set to 4x scroll clicks per single click of the wheel, which means that sometimes you'll be at the bottom of a page, scroll down to turn, and end up turning AND scrolling down on the next page. This makes it's extremely annoying to try use.

5. Add an option to display a progress bar at the bottom.
A horizontal bar along the bottom of the window showing the progress into an issue would be nice, an alternate to the 'show info' version of "13/23 - TIME". Your naturally looking at the bottom of the wind when about to turn the page, so having the progress shown there would be convenient. It's also a visual indicator opposed to a text one. It would also be nice if it wasn't an overlay that would cover the page.

6. Add an option to remove the time from the show info box.
I've already got a clock on my screen, I do not need another. It makes the overlay box larger for negligible value. Maybe only display the clock it when in full screen mode?

It was quite a pain to install this from the AUR, took like an hour to compile. Alternatively, a precompiled binary package for Arch would be great as well.

A recently added list would make a world of difference trying to find where all my new books are.

My first thought was to simply make a sub-folder called "Added," however if I wanted to add these books back to my main collection folder later, all previous tags are removed in the process. Having a "Recently Added" list would alleviate this problem issue greatly with relative ease.

Hello ,
I use Arch linux recently installed YacReader Library for reading comics, grids views ( that does not work) ,
so I launched through the terminal to see what ticks and I got:
ERROR 2018-08-10T04:09:54.799 (qrc:/qml/GridComicsView.qml:6:1: module "QtGraphicalEffects" is not installed)
so I tried to install it , but there is a bug on my distribution about this package , I was wondering if it was possible for yacreader to propose an alternative to this package

Hello there.

I'd like to get involved in YACreader a bit, but have very little experience in C++ and QT programming.
I'm going to write a small list of features that I would like to see implemented. If some of you folks could suggest which ones would be the easiest to start working on for a newcomer (i.e. that don't need major redesigns of the whole platform and/or extensive knowledge of the codebase), I would be happy to get my hands dirty!

Here goes:

• Add the possibility to sort a library folder by clicking on a column header in the list view
• Add advanced filtering options (find comics by writer, title, characters, etc.). This is most likely the hardest thing on the list but it would be really neat.
• Dependent on the above: Allow navigation by clicking on tags in grid view (so for instance, if I click on an author name I see all comics by that author)
• Allow renaming folders from within the library (rather than having to do it from the file system)
• Allow choosing which columns to display in the list view (with a dropdown that allows you to select the fields you want to see)
• Improve comicvine integration - unless I'm doing something wrong, at the moment the search is broken and finds a huge amounts of irrelevant comics.
• Improve how tags are stored - at the moment, everything is stored in a database (I think?). It would be nice, I think, to store tags directly in the cbr/cbz archive - even better in a way that is compatible with ComicRack format.
• (subject to discussion) somehow integrate with https://github.com/comictagger/comictagger . They have a really good automatic tagger (also based on comicvine), unfortunately it can only save tags in ComicRack format so it's not usable with YACreader
• Improve filesystem integration and maybe give the option for YAClibrary to automatically organize files and folders (similar to how Itunes does it) - i.e., automatically organize comic files in folders by series, for instance.
• Allow reordering of pages inside a comicbook - sometimes the images inside the cbr/cbz file are not in the right order. It would be nice to be able to reorder them.
• Add an "All Comics" view - at the moment it's only possible to view the contents of a single folder at a time. I realize this could bring a serious performance problem on large libraries, so I'm not sure how it should be approached.

This is all for now, although I may add some later as I think of them :-)

Cheers!

This is basically a requested issue from the forums.

The error is:

ERROR 2019-07-03T22:38:43.681 (qrc:/qml/GridComicsView.qml:439:9: Cannot assign object of type "Component" to property of type "QQuickItem*" as the former is neither the same as the latter nor a sub-class of it.)

We're still using the outdated and deprecated Qt Script for our ComicVine scraper. This is no longer shipped in default Qt installations, so it makes the build process slightly more complicated and could lead to problems in the future. It is also a dependency we could get rid of.

We should migrate the scraper code to QJSEngine.

reading INSTALL.md and the CHANGELOG.md looks like Qt >= 5.6 is needed, so I tried to build latest 9.5.0 on the latest Slackware (I'm the maintainer on SlackBuilds.org), with qt-5.7.1 but I had these errors

make[1]: Entering directory '/tmp/SBo/yacreader-9.5.0/YACReader'
g++ -c -pipe -std=c++11 -O2 -fPIC -Wall -W -D_REENTRANT -fPIC -DNOMINMAX -DYACREADER -Duse_unarr -DLIBDIR="/usr/lib64" -DDATADIR="/usr/share" -DQT_NO_DEBUG -DQT_OPENGL_LIB -DQT_WIDGETS_LIB -DQT_MULTIMEDIA_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I. -I../common -I../custom_widgets -I../common/gl -I../custom_widgets -I../compressed_archive/unarr -I../shortcuts_management -I../QsLog -isystem /usr/include/poppler/qt5 -isystem /usr/include/poppler -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtOpenGL -isystem /usr/include/qt5/QtWidgets -isystem /usr/include/qt5/QtMultimedia -isystem /usr/include/qt5/QtGui -isystem /usr/include/qt5/QtNetwork -isystem /usr/include/qt5/QtCore -I. -I/usr/lib64/qt5/mkspecs/linux-g++ -o main.o main.cpp
main.cpp: In function ‘int main(int, char**)’:
main.cpp:86:11: error: ‘class QCommandLineOption’ has no member named ‘setFlags’
comicId.setFlags(QCommandLineOption::HiddenFromHelp);
^~~~~~~~
main.cpp:86:40: error: ‘HiddenFromHelp’ is not a member of ‘QCommandLineOption’
comicId.setFlags(QCommandLineOption::HiddenFromHelp);
^~~~~~~~~~~~~~
main.cpp:87:13: error: ‘class QCommandLineOption’ has no member named ‘setFlags’
libraryId.setFlags(QCommandLineOption::HiddenFromHelp);
^~~~~~~~
main.cpp:87:42: error: ‘HiddenFromHelp’ is not a member of ‘QCommandLineOption’
libraryId.setFlags(QCommandLineOption::HiddenFromHelp);

looking at the Qt documentation

http://doc.qt.io/qt-5/qcommandlineoption.html#setFlags

seems like some functions has been introduced with Qt >= 5.8.

Previous versions of YACReader supported the .cb7 format. Is there any way 9.5 could as well?

I assume this same issue might occur on other Linux distros. When right-clicking any file (I am testing with .cbr files) in YACReader Library while in Grid View, the application quits immediately after. It doesn't occur on the right-click. Instead, it occurs on the next action, which is usually either escaping the right-click menu or selecting an action from it.

I'm trying to set up a new library running on a small VNC session that uses XFCE running on Ubuntu Server 18.04. I installed the Ubuntu repo and pulled the appropriate package to install, so far so good.

Creating a library mostly works (small error is that typing into the name box thinks my keyboard layout is something completely different but I was able to copy/paste in) and the scan proceeds showing my library of comics being scanned. However once that's done (or if I stop the scan) I get the following screen:

That error message appears to say "Error opening the library". I get the same message if I close YACReader Library and re-open. What's going on here? Any log file I can check?

I had version 9.0 installed on my Widows laptop. I installed 9.5 with 7zip support. Now it wont open any comic files.

I would appreciate the addition of some authentication scheme for the access to the library. This should (hopefully) be simple to add to the HTTP requests (e.g. digest authentication). This makes sense only if you're willing to add this to die iOS Client, too. :)

It would be neat if there was an option to hide the title bar, for those of us who are using tiling window managers (like chunkwm) on OS X.

It is easy enough to do this by adding a line to main_window_viewer.cpp:

    setWindowFlags(Qt::CustomizeWindowHint | Qt::NoDropShadowWindowHint);

I have successfully compiled my own copy that disables the title bar in this way, but I saw that there is
commented out code for an "always on top" configuration option that looks like it could easily be adapted to this purpose as well?

The source code is in a bad state. It almost turned me away, but I was interested in learning how to clean up legacy C++ code, so I stuck around. But I'm sure it will discourage potential contributors.

• The most visible problem is the lack of a consistent indenting: in a single function, it can switch between 2 spaces, 4 spaces and tabs.
• The one-command blocks usually have no braces. It sometimes leads to ambiguous code in sequences like "if if else". But combined with inconsistent indenting, reading the code is a real pain: when several lines are indented like they were inside the block, is it a indentation error or were the braces forgotten?
• There are many small errors that compilers detects (shadowing global vars, .

The pull request #43 has fixes that remove all the warnings when compiling with g++ 8.3.

Since then, I've used Clang tools to format the source code and enhance the syntax (especially adding braces). It was almost necessary before I could begin adding features. I also fixed the warnings that compiling with Clang detected. I did not create a PR since the prerequisite #43 is still staging, but if you are interested, I could rebase out a few unrelated commits and make this PR. If you want to look at it, my branch is named "clang-tidy" in my fork.

The solution to this is to disable app code sign on PRs coming from forks.

Platform

• YACReader/YACLibrary 9.6.2
• Qt 5.13.2 on Linux, 64bit, ArchLinux
  • Also reproduced with Qt 5.14.0
• Desktop: KDE Plasma 5.17.4 on X11

Issue

In the library, the action buttons in the reading list pane's header (create list, create label, edit, delete) in the sidebar are often not clickable because the cursour turns into resize shape on mouseover in the entire header region. The pane can then be successfully resized but the underlying buttons can't be clicked:

This occurs every time on casual mouseover. However, depending on the "angle of attack" on the button area and a random combination of alt/ctrl/shift keys pressed, sometimes the cursor turns out normal (in arrow mode) and the buttons then can be clicked.

I suspect something about the mouse event handling in this area being a bit awry.

Expected behaviour

The cursor should remain in array mode when over the header bar button area.

looks like total pages number creating only 1 time at first indexing.
for update ongoings i use Manga Reader.

The windows installer installs the program in C:\Program Files which is normally only writable by privileged users. However the installer sets custom privileges on the install directory which allow it to be written to by any user on the system which is both unexpected and undesirable from a security standpoint.

We should use our new CI system to run lupdate on our source code whenever we do a (pre)release. We should publish the generated translation source files as a separate download alongside the release.

This has several advantages:

• we don't have to worry about our translation files being up to date
• translators can just grab the new sources and start working once we entered the release process
• the entry threshold for creating or improving a translation is considerably lower

We'll need to think about how we'll be re-integrating the generated files into git though.

I import Vine tags, i want edit tags and crash.

crash log.txt

unarr supports 7z now.

Steps to reproduce:

0. Disable hardware acceleration in YACReader options.
1. Open a comic book (cbr or cbz). The bug happens more often for large comics (>=100 pages). Also seems to happen more often when opening by double-clicking in YACReaderLibrary. A comic book never opened in YACReader before is preferable.
2. If the YACReader CPU usage goes down to 0-1% after a few seconds, exit YACReader and open the same comic again. This time the CPU usage will likely stay high, e.g. 25% on a 4-CPU-core system.

I tried to debug the issue in Qt Creator by interrupting YACReader built in Debug mode while it was using the entire CPU core. But the call stack didn't indicate a problem in any thread. Tried QML debugging in Qt Creator, but it didn't work on my system for some reason.

System and versions: Manjaro Xfce x64 with latest updates; Qt 5.12.3; https://aur.archlinux.org/packages/yacreader with CONFIG+=no_pdf instead of CONFIG+=pdfium.

EDIT: the same issue happens when compiling the develop branch in Qt Creator using the default poppler PDF backend.

Simply start and exit YACReaderLibrary built in Debug mode in Qt Creator and examine the Application Output tab to reproduce.

Some of the warnings repeat many times on different lines. I pasted only unique errors below:

QLayout::addChildLayout: layout "" already has a parent 
qrc:/qml/FlowView.qml:35: ReferenceError: backgroundImage is not defined 
qrc:/qml/FlowView.qml:86: ReferenceError: comicsList is not defined 
qrc:/qml/ComicInfoView.qml:54: ReferenceError: comicInfo is not defined 
qrc:/qml/ComicInfoView.qml:145: ReferenceError: comic is not defined 
QObject::connect: No such signal LibraryCreator::failedUpdatingDB(QString) in ../../yacreader/YACReaderLibrary/library_window.cpp:999 
QSqlDatabasePrivate::removeDatabase: connection '/home/igor/Constant/comics/.yacreaderlibrary/library.ydb7fffedf38d40' is still in use, all queries will cease to work. 
QSqlDatabasePrivate::removeDatabase: connection '/home/igor/Constant/comics/.yacreaderlibrary7fffedf38d40' is still in use, all queries will cease to work. 
QSqlDatabasePrivate::addDatabase: duplicate connection name '/home/igor/Constant/comics/.yacreaderlibrary7fffedf38d40', old connection removed. 
qrc:/qml/FlowView.qml:76:5: QML ListView: Binding loop detected for property "model"

At now, when you have turned on the option to fit image to height/width/page, small images becomes larger than their own sizes. We need an option to stop this behavior.

Don't enlarge small images more then their original size.

"Small" images are images that are smaller than the screen size in one or both dimensions.

I have my current library on Linux and use Paragon ExtFS for mounting all my drivers into windows without any problems for years. The issue is that I cannot import that folder nor even create a new empty one on those partitions because of this weird error:

When I restart the app, the apps says that the library was created with an older version and has to be recreated. The metafile within the library folders is completely empty.

The logs shows nothing, just an empty line with the error I am already seeing on the app.

ERROR 2019-02-08T21:52:25.657 Unable to create data base "out of memory-Error opening database" 

I cannot use the app at all cause all my partitions are ext4, except the windows and a small one that I am already using for Steam.

If need any more info, please let me know and I'll update this ticket.

This issue is an offshoot of the discussion that began in the forum

Please provide support for reading metadata files written by other comic readers such as (but not limited to) ComicRack.

As far as ComicRack is concerned, metadata support would entail reading an .xml file that can be backed up to any location by the user or one stored within the comic file. The first is stored by default in C:/Users/%user%/AppData/Roaming/cYo/ComicRack/ComicDb.xml if direct import is to be supported by YAC.
Relevant links:
http://comicrack.cyolito.com/software/windows/windows-documentation/7-meta-data-in-comic-files
http://comicrack.cyolito.com/forum/8-help/26757-where-is-the-metadata-stored

The program starts and runs only in English interface language.
Program version 9.6.0 - 9.6.2

I don’t know about other languages, in my windows 7x64 only Russian and English language packs are installed.

In version 9.5.0, such a bug is not observed. After installation and launch, the program works with the Russian interface language.

On YACReader Library, when you select a folder in your library that is composed of subfolders (which in turn may contain library galleries, or more subfolders), you only get a plain text list of subfolders, even in grid view.

Would it be possible to display a regular thumbnail instead (for example, using the first gallery that is found inside the subfolder)? I think it would make the library easier to navigate.

Hello, my name is Pedro,
Thanks to your wrapper I managed to use 7-zip in my project, but recently I have managed to update it to use it with the latest versions of the 7-zip sdk as of p7zip ie use the 19.00 and 16.02 respectively, this way you can read files rar5

The project is Qt7zip comes with examples and I hope it helps you to update your wrapper and to be able to use the new 7-zip and p7zip libraries, in your wonderful reader comic.

Sorry for my English

Hola me llamo Pedro,
Gracias a tu wrapper conseguí usar 7-zip en mi proyecto, pero hace poco he conseguido actualizarlo para usarlo con la ultimas versiones del sdk de 7-zip como de p7zip es decir usar la 19.00 y 16.02 respectivamente, de esta manera ya puede leer archivos rar5.

El proyecto es Qt7zip viene con ejemplos y espero que te sirva para poder actualizar tu wrapper y poder usar las nuevas librerías de 7-zip y p7zip, en tu magnifico lector de cómic.

Un saludo.

When I refer to a file with a symlink, the library detects it and includes it as if treating the original file.
However, when I try to open it, yacreader gives "format not supported" error. I guess it is trying to open the symlink itself and not the linked file. I think this is an issue to fix.

It would be great to have an option for having uneven pages on the right side, like real books.

It seems more natural the direction key used to flip pages should follow the flow of the page, which in Manga Mode is the other way around. At the moment the Right directional keys goes to the next page regardless of in Manga mode or not.

I delete .qm files for my locale. But it is not proper way for this situation.

Hello,

I'm trying to setup a server using my raspberry pi 3 model B and I'm getting an error with the Title Server Version in the iOS app. It says: "You need YACReaderLibrary 9.5.0 or higher".

The error is pretty clear, but the problem is that I created the lib using the version 9.5.0.

I tried to upgrade a old version lib (9.0.0) using the YACReaderLibraryServer by command line, without success. I tried upgrading the lib using the desktop version, but nope and I tried creating a new one, using the desktop version 9.5.0, but sadly the same erro.

The problem seems to be related with the iOS app, because I can import, without problem, using the desktop app.

I don't know what more I can do :p could you help me, please?

Thanks in advance.

iOS version: 3.0.1
Desktop: W10
Raspberry pi: 3 Model B
Raspberry OS: Linux raspberrypi 4.14.50-v7+
YACReaderLibraryServer 9.5.0

While not too common, there are some occasions, especially when it comes to things like webcomics, where animated gifs are used. It would be nice for yacreader to support this feature.

i've downloaded Version '9.5.0' but when selecting it in the Finder and using 'Get Info' it doesn't show any Version-number at all. i guess the CFBundleVersion and CFShortVersionString entries in your Info.plist file are missing

Toolbar hiding by shortcut is confusing, not easily found by new users (see #104) and it is possible to lock yourself out of the toolbar by pressing the button by accident. This bug is a reminder for me or @luisangelsm that we should fix this.

Here's an example.

Also, have you tried the sponsor link? Would that be beneficial, more money to afford you more time to work on YACReader? I dream of using an android version one day...

The purpose of importing tags from Comicvine is lost. There has to be smarter lists suggestions based on story arc and crossovers, and importing comics based on those into reader.