yanchenglee98 / pe Goto Github PK

When a index that exceeds the number of attractions is provided to edit-attraction, it says "At least one field to edit must be provided" which is confusing to the user as it implies that 20 is a valid index

Would be good to be similar to delete-attraction and state that index is invalid

after edit-itinerary-attraction, the chronological order is msed

Due to the limitation of plantUML, the lifeline does not end at the destroy marker. But this disclaimer only specifies it for DeleteCommandParser.

Would be good to put a disclaimer at the top of the DG stating that all PlantUML diagrams will have the same limitation

find-itinerary parses invalid dates such as find-itinerary 35-09-2020.
Would be good to inform user that date is invalid instead of just displaying an empty list

the clear-attraction command can accept extra parameters. Eg. clear-attraction abcd

This was placed as a note in list-attraction which was good. But it is even more vital to put it in clear-attraction since this command is irreversible

In add-attraction UG defined duplicate attractions as same name AND location.

But it seems to only check for name of attraction as they can be duplicate location

Some key terms such as attractions and itinerary are not in the glossary. They were explained in their respective sections but would still be good to put it into the glossary section for easy reference.

Find command in general works for most keywords such as jurong and trick eye musuem.

But for some reason the keyword singapore zoo or zoo singapore keyword will list all attractions. Seems like all attractions contain singapore zoo.

Steps to replicate:

1. Use the default data by deleting the .json file
2. Enter find-attraction singapore zoo