yanlisa / tmoss Goto Github PK

The README states that the file structure to store the MOSS binary should be:

code/
    bin/
        moss

however pymoss looks within its own directory for the bin folder, so either the code needs to fixed to look for code/bin/moss or the directory structure in the README should be:

code/
    pymoss/
        bin/
            moss

The culprit for this is in code/pymoss/runner.py on line 12:

BINARY = os.path.realpath(os.path.join(os.path.dirname(__file__), "bin", "moss"))

which appends bin/moss to the directory /path/to/tmoss/code/pymoss/

The way MOSS is run in pymoss is broken and there is no clear fix from the code as given. There are comments that reference the flags set for the perl script and none of them exist within the mossnet perl script. In tmoss/code/pymoss/runner.py, it sets the MOSS flags as follows:

        # These options were hard-coded in the Perl script (some were vars but not user-settable).
        MAGIC_ARGS = ["-p", "24", "-t", "26", "-g", "10", "-w", "5"]

        args = ["-n", str(threshold), "-a", manifest, "-o", results]

Of these flags, only -n and -p are valid MOSS flags (and setting the port to 24 seems incorrect). It is unclear through reading the code as to the intent of the flags in MAGIC_ARGS. I am assuming the -a and -o have something to do with how the files are input and results are output, but that is also unclear. I don't see any variables within the MOSS script that can be hard-coded to the MAGIC_ARGS values, either.

If one removes MAGIC_ARGS and the -a and -o flags, then MOSS is run without any files as input. The value on execution of manifest is the string "manifest" and results contains the string "results". It would be very beneficial to see a copy of the version of MOSS used when using this tool to determine how to proceed or update this to work with the current MOSS. The software, as is, is inoperable.