yapplabs / ember-cli-bourbon Goto Github PK

View Code? Open in Web Editor NEW

55.0 9.0 15.0 279 KB

Include bourbon in an ember-cli app.

License: MIT License

JavaScript 78.65% CSS 6.45% HTML 14.90%

ember-cli-bourbon's Introduction

ember-cli-bourbon

Include bourbon in an ember-cli app.

Dependencies

Your project should already be set up to handle sass/scss builds. If you're not, do so by running:

ember install ember-cli-sass

Usage

In your ember-cli (>= 0.1.1) project, run:

ember install ember-cli-bourbon

The generator will create an app.scss with the sole contents being:

@import "bourbon";

If you already have content in your app.scss, you can add that line to the top of app.scss yourself.

Choosing your version of bourbon

If you install a version of bourbon greater than 5.0.0 in your application this addon will detect and use that version instead of the default one. This is useful if you want access to the newest bourbon features and this addon is not updated right away:

npm install [email protected]

ember-cli-bourbon's People

Contributors

Stargazers

Watchers

Forkers

tsharman fauxton jens-a-e abulrim ljuti heroiceric greyhwndz joedaniels29 andremalan sohara tubbo ivanvanderbyl jrjohnson isabella232

ember-cli-bourbon's Issues

Unable to install import Bourbon on Ember 0.2.2

Node: 0.12.0
npm: 2.7.4
Ember: 0.2.2

Steps to reproduce:

Setup an ember cli project with Ember 0.2.2
Run npm install ember-cli-bourbon --save-dev
Run ember s

Expected Result: Successful compile with no deprecation warnings.
Given Result:

$ ember s
version: 0.2.2
[Deprecated] this.pickFiles is deprecated, please use broccoli-funnel directly instead  [addon: ember-cli-bourbon]
Livereload server on port 35729
Serving on http://localhost:4200/

ENOENT, no such file or directory '/Users/benmorgan/Sites/ember_app/frontend/tmp/funnel-dest_fJP49r.tmp/'
Error: ENOENT, no such file or directory '/Users/benmorgan/Sites/ember_app/frontend/tmp/funnel-dest_fJP49r.tmp/'
    at Error (native)
    at Object.fs.readdirSync (fs.js:765:18)
    at /Users/benmorgan/Sites/ember_app/frontend/node_modules/ember-cli/node_modules/broccoli-merge-trees/index.js:32:21
    at Array.map (native)
    at mergeRelativePath (/Users/benmorgan/Sites/ember_app/frontend/node_modules/ember-cli/node_modules/broccoli-merge-trees/index.js:30:29)
    at /Users/benmorgan/Sites/ember_app/frontend/node_modules/ember-cli/node_modules/broccoli-merge-trees/index.js:23:5
    at lib$rsvp$$internal$$tryCatch (/Users/benmorgan/Sites/ember_app/frontend/node_modules/ember-cli/node_modules/promise-map-series/node_modules/rsvp/dist/rsvp.js:489:16)
    at lib$rsvp$$internal$$invokeCallback (/Users/benmorgan/Sites/ember_app/frontend/node_modules/ember-cli/node_modules/promise-map-series/node_modules/rsvp/dist/rsvp.js:501:17)
    at lib$rsvp$$internal$$publish (/Users/benmorgan/Sites/ember_app/frontend/node_modules/ember-cli/node_modules/promise-map-series/node_modules/rsvp/dist/rsvp.js:472:11)
    at lib$rsvp$asap$$flush (/Users/benmorgan/Sites/ember_app/frontend/node_modules/ember-cli/node_modules/promise-map-series/node_modules/rsvp/dist/rsvp.js:1290:9)

needs release

git pull
npm publish

should be sufficient, I already bumped the versions + tagged

cc @lukemelia

How could I update to bourbon 5x?

I installed as directed and everything worked great - but after using a somewhat less convenient method of getting neat on my project I then found a similar way of getting bitters on and once I got that in place I ended up discovering that bitters wont work w/o a 5x version of bourbon ... so I manually updated the bower bourbon package only to get a broccoli error (I'm guessing relating to ember-cli-bourbon?) - sorry for not being specific here - but something along the lines of "filepath being watched unavailable or doesnt exist" ... well it turns out that the .scss files in the new 5x bourbon package are at the end of a slightly different filepath - which I now assume is why I got that error - so I'm wondering if you had any insight on how to change ember-cli-bourbon to be looking in the NEW(er) path?

Don't override app.scss/sass

Seems a little forceful to try and over-ride app.scss when you can simply suggest adding the import after the fact. I can only see this creating a nasty scenario more than it is helpful. Happy to submit a PR if you agree.

don't use bower

would you consider a pull request which got rid of bower along the lines of ember-cli-moment-shim
(see https://github.com/jasonmit/ember-cli-moment-shim/blob/master/index.js)
The idea is to import the front-end dependency as an npm dependency, then use require.resolve to look up the path in ember-cli-build.

Missing dependency on `resolve`

resolve is required unconditionally here:

ember-cli-bourbon/index.js

Line 5 in 9e6d7ad

const resolveSync = require('resolve').sync // eslint-disable-line

No dependency exists for resolve in the package.json...

[Deprecated] this.pickFiles is deprecated warning for ember CLI 0.2.3

After install of ember-cli-bourbon addon to ember cli 0.2.3 project, starting the server gives me
[Deprecated] this.pickFiles is deprecated, please use broccoli-funnel directly instead [addon: ember-cli-bourbon]

Problem building after upgrade to ember-cli 0.1.2

➜  participate-frontend git:(upgrade-cli) ✗ ember build
version: 0.1.2
Build failed.
ENOENT, no such file or directory 'bower_components/bourbon/dist/'
Error: ENOENT, no such file or directory 'bower_components/bourbon/dist/'
    at Object.fs.lstatSync (fs.js:679:18)
    at symlinkOrCopySync (/Users/work/Projects/participate-frontend/node_modules/ember-cli/node_modules/symlink-or-copy/index.js:19:12)
    at CustomStaticCompiler.StaticCompiler._copy (/Users/work/Projects/participate-frontend/node_modules/ember-cli/node_modules/broccoli-static-compiler/index.js:59:3)
    at /Users/work/Projects/participate-frontend/node_modules/ember-cli/node_modules/broccoli-static-compiler/index.js:25:12
    at $$$internal$$tryCatch (/Users/work/Projects/participate-frontend/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:470:16)
    at $$$internal$$invokeCallback (/Users/work/Projects/participate-frontend/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:482:17)
    at $$$internal$$publish (/Users/work/Projects/participate-frontend/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:453:11)
    at $$rsvp$asap$$flush (/Users/work/Projects/participate-frontend/node_modules/ember-cli/node_modules/rsvp/dist/rsvp.js:1531:9)
    at process._tickCallback (node.js:415:13)

my package.json.

I have ember-cli-bourbon under both devDependencies and dependencies, since switching to dependencies made ember build not recognize the ember-cli project.

Full update details on this pull request. I tried to follow this guide to upgrading, but have been shooting in the dark regarding updating the addons.

I don't fully grasp dependency management with bower and npm (coming from ruby) - please bear with me :)

Does not work with sass file

Is there a reason I cannot simply add @import "bourbon" to my app.sass file? I get the following error:

Error: file to import not found or unreadable: bourbon
Current dir: /Users/jdillon/Documents/work/project/tmp/tree_merger-tmp_dest_dir-2WDpffwx.tmp/app/styles/
    at options.error (/Users/jdillon/Documents/work/project/node_modules/ember-cli-sass/node_modules/broccoli-sass-source-maps/node_modules/node-sass/lib/index.js:276:32)

The project I've hopped on is set on sass.

Also, what do you mean by:

If you already have content in your app.scss, you can just choose "n" and add that line to the top of app.scss yourself.

Thanks