yaroslavche / bitmask Goto Github PK

Hi,

I like what you've been working on here. Not sure how active the project is for you still but I had an issue to discuss. Hopefully I've missed something here, so before I investigate too much further I thought I would ask you first.

The following test results in an unexpected Exception.

$bitmask = new AssociativeBitMask(['readable', 'writable', 'executable'], 1);

$bitmask->isReadable(); // True
$bitmask->isWritable(); // Exception thrown  "Undefined offset: 1" from line 68 (AssociativeBitMask class).

It looks like the constructor (set() method) is not correctly initialising the internal map property for the AssociativeBitMask.

The above example, yields

map = [
 0 => true
]

But I'd expect,

map = [
 0 => true,
 1 => false,
 2 => false
]

Am I missing something, or does the set() method need to initialise all map values?

A similar issue occurs if the mask value is initially set with all bits on, and then altered.

$bitmask = new AssociativeBitMask(['readable', 'writable', 'executable'], 7);

Correctly generates the following map,

map = [
 0 => true,
 1 => true,
 2 => true
]

Then updating the mask,

$bitmask->set(1);

Yields an unexpected map array,

map = [
 0 => true,
 1 => true,
 2 => true
]

Thanks.

Hi @yaroslavche,

thanks for this package! We saw, that you had removed the old releases. We have a project depending on version 0.2.0. It cannot be upgraded to version 1.0.0, because the minimum php-version changed. Is there a specific reason that you removed the old releases (like a bug, a security-concern, ...)?

Thanks in advance!

$this->map = array_fill(0, count($keys), false);

*

Should be

$this->map = array_fill(0, count($keys) - 1, false);