Giter VIP home page Giter VIP logo

agama-cli's People

Contributors

imobachgs avatar jreidinger avatar mvidner avatar

Stargazers

 avatar

Watchers

 avatar  avatar  avatar  avatar

agama-cli's Issues

Add support for alternative add syntax

Recently, we introduced support to specify collections through the command line. While working on that change, I decided to change the storage.devices key from a list of strings ([/dev/sda]) to a list of objects ([{ "name": "/dev/sda" }]). The rationale behind that change is that we can extend that element later keeping backward compatibility. For instance, think of:

[
  { "name": "/dev/sda", "partitions": [1, 2] },
  { "name": "/dev/sdb" }
]

It implies changing the example from the CLI proposal:

$ dinstaller config add storage.devices /dev/sda

to something like:

$ dinstaller config add storage.devices name=/dev/sda

However, for convenience, we could support both syntaxes.

Reduce the number of D-Bus calls

As a first PoC, we read and write all the settings, which implies a lot of D-Bus calls and might cause some unwanted side-effects. We need to change the approach to reduce the number of calls and changes.

We do not need to implement any complex logic. As a first step might be to just read/write information from the affected services. For instance, the next call should only read/write from/to the storage service:

dinstaller-cli config set storage.lvm=true

Improve test coverage

As Rust newbies, we have been relying on the type checking and not writing so much unit tests. We
might need to change that trend and start writing proper tests to make sure the logic is right.

Merge settings collections

Collections are just ignored when merging the settings. We need to apply the same behavior that we use in other settings.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.