yeahframeoff / laravel-and-music-and-more Goto Github PK

I found it useful to make some review of your code as I see some aspects that would be critical when working.

1. Could you make your app id and client server as some const variables outside the index method so that we soon can easily move them into app/config/app.php
2. I would strongly recommend you use Session facade to work with session data instead of using native php method. That thing is critical because pure-php session_destroy() would delete some crucial extra data (e.g. "_token" in forms) stored by the Laravel framework.
3. Could you please explain in simple words how the process goes in facebook? As I see, when user not logged follows the link, he sees request for access to his personal data. After that the browser is redirected and here the request should be caught by the controller and the access token should be extracted from the response. I'm wondering: does the facebook use this token to access the API method, or he needs some additional temporary token that is retrieved from the first token and that is used to make calls to api and that expires in some period of time?
4. Could you please return results of View::make() as the result in the end of the method?