yearn / ygov-finance Goto Github PK

When voting, the currently staked funds in pool 3 (governance pool) are locked for some duration. So far so good.

Now, when one deposits and stakes additional funds to pool 3 after voting, the additional funds are locked as well. The UI in this case does not allow to unstake, indicating that one needs to wait until the lock period ends.

Is this a UI limitation or is unstaking indeed not possible for the additional funds ?
If unstaking not possible, is this intended behavior ?

I find this surprising. Better would be if only the amount is locked that was used to vote.

Balance shows 0.000 even if user has a positive balance of staked yfi.

Example of the available information for each proposal:

====== PROPOSAL #0 ======
- Minting more $YFI - 

FOR     : Allows weekly distribution of YFI. A second proposal will be submitted to decide how much would be printed weekly.
AGAINST : No more YFI tokens will be distributed. Global supply is locked at 30000 YFI permanently.

https://twitter.com/iearnfinance/status/1284454945614442499

Proposed by         : 0x473afAb58B2C5D4DbC5FAD5D236f6658AD84E83b
Total for votes     : 3435983.4406505744 (41.15%)
Total against votes : 4913869.508808158 (58.84%)
Start block         : 10490942
End block           : 10508222

====== PROPOSAL #1 ======
- Burn $YFI for fees - 

yearn.finance is currently earning $60k/week in protocol fees, which can grow in the future with yearn.finance ecosystem growth and new products.

FOR     : Will continue to with the current burn model.
AGAINST : Rewards will be claimed via a staking model instead.

https://twitter.com/iearnfinance/status/1284531647078178816

Proposed by         : 0x473afAb58B2C5D4DbC5FAD5D236f6658AD84E83b
Total for votes     : 502445.8576 (11.48%)
Total against votes : 3870866.548141156 (88.51%)
Start block         : 10490942
End block           : 10508222

Claim & unstake fails 100% of the time
Voting creates a 3-day lockup. You can only claim rewards during lockup, not after it. You can only unlock after, not during. So those two are mutually exclusive. seems like this bug was carried over from the v1 pool 3 contract. Im sure people know about this already just posting here incase. If this is fixed already or in the works just let me know.

Where can one find the smart contracts that this front-end references?

If there is a github repo a submodule contracts would be useful but at least a link in README.md to the contracts.

Staked ycurve token via "https://www.curve.fi/iearn/deposit". It successfully staked. When checking the staked amount via https://ygov.finance/staking -> yearn with Ledger Nano S, BALANCE-CURRENTLY STAKED-REWARDS AVAILABLE are all 0. When connected with MetaMask to the same ETH address, BALANCE-CURRENTLY STAKED-REWARDS AVAILABLE displays properly.

Seems like there is something wrong with Ledger Nano S connectivity.

This is how mobile screen looks like:

It essentially misses following info:

This is not only Trust wallet issue, got same feedback on Metamask Mobile.

I've asked people for feedback and received pretty long list: https://gov.yearn.finance/t/time-to-get-our-shit-together/173/9.

Should I put each bullet point as separate issue in this repo or will you take over from forum?

cc @antonnell

Make it apparent in the UI before voting that this action will lock their YFI for 3 days.

Reference:

https://twitter.com/iamDCinvestor/status/1300071438477557761?s=20

Maybe show a third option along with done and open of "Voted"

I think this subgraph can be used to get the list of ballots a voter has participated on
https://thegraph.com/explorer/subgraph/crazyrabbitltc/yearngovernance
Since don't see at quick glance if the contract has a query option for this.

When "Balance: 0.0000 YFI" is clicked user gets 4-digit precision. Would be great to use whole balance – all 18 decimals.

People complain that there is no feedback after voting and it is not clear if they voted or not:

https://gov.yearn.finance/t/yearn-interaction-feedback/1321/3?u=milkyklim
https://gov.yearn.finance/t/yearn-interaction-feedback/1321/4?u=milkyklim

Hi mods - can you add the voting deadline for each proposal once it goes on-chain? This is important information and it is missing both from the forums and https://ygov.finance/vote

Source: https://gov.yearn.finance/t/proposal-deadlines-missing/364

From chat:

@milkyklim The web3 provider for portis. When you select portis to login your logo and company name should be there. Its not. Whoever did the integration needs to go to https://dashboard.portis.io and upload correct logo and company name for the correct Dapp ID.

Lightbulb should be company logo and codesandbox should be yearn.finance