yeled / napalm-opengear Goto Github PK

How should we best support get_users() and support changing password hashes?

Is it all in /etc/config/shadow? are they hashed in a secure way?

Finding the groups would also be beneficial. I know how to set and remove groups with user-mod and tbh I prefer to delete the user and start afresh as I've seen group changes not "stick" (just anecdotally) when trying to remove them with that tool.

If we remove and delete users every time people might be surprised their ~ disappears.

Leaving XML aside for now, probably a v2 feature..

How do we want to expect the NAPALM template to configure the action of "delete" vs "set"?

@fjaeckel and I spoke about this on Slack and thought that matching the config setting of "if a var is missing, it's a delete.

config -d var.foo

If the var is set (we can match a literal = character) then it's a config -s var.foo=quux.

var.foo=1
{% some stuff %}
quux.bar={{ some["stuff"] | default("Hello") }}
baz
{% some other stuff %}

Would come to:

config -s var.foo=1
config -s quux.bar=Hello
config -d baz

What do you think @r0bertw ?

The only problem I see is that it's hard to immediately spot, if you had hundreds of lines of var=foo, and one was missing a = it might take a lot to find out why some config was being deleted.

We could explicitly just pass the -d and the -s from the template, but then a config -g config wouldn't be restorable, you'd need to insert a -s before each line.