paasta-tools-go's Introduction

paasta-tools-go

Go library for interacting with PaaSTA

Troubleshooting

How to clone

The project must be clonned via https as it is required to perform SSO, this means no push via ssh would work.

Private libraries

You may need to export the following env variable

export GOPRIVATE=*github.yelpcorp.com

otherwise doing go mod tidy will have problems finding the monk library.

paasta-tools-go's People

Contributors

Stargazers

Watchers

paasta-tools-go's Issues

SetKubernetesObjectHash doesn't update hash if already set

(making a github issue since I'm too lazy to get my work laptop and make a normal ticket for now)

If we update the test to SetKubernetesObjectHash to try and set the hash again of an object (maybe after it is mutated, or something) like so:

index 1e1b4a8..c5c2908 100644
--- a/pkg/hashing/hashing_test.go
+++ b/pkg/hashing/hashing_test.go
@@ -154,6 +154,15 @@ func TestSetKubernetesObjectHash(t *testing.T) {
        assert.NotEqual(t, someStatefulSet.Spec.Template.ObjectMeta.Labels["yelp.com/operator_config_hash"], "abc1234")
        // but the existing labels are
        assert.Equal(t, someStatefulSet.Spec.Selector.MatchLabels["yelp.com/rick"], "andmortyadventures")
+
+       // Now let's try updating the object with a new hash
+       err = SetKubernetesObjectHash("def5678", someStatefulSet)
+       if err != nil {
+               t.Errorf("Failed to add label")
+       }
+       // the new label and existing label are present in ObjectMeta
+       assert.Equal(t, someStatefulSet.ObjectMeta.Labels["yelp.com/operator_config_hash"], "def5678")
+       assert.Equal(t, someStatefulSet.ObjectMeta.Labels["yelp.com/rick"], "andmortyadventures")
 }

We get the following error:

--- FAIL: TestSetKubernetesObjectHash (0.00s)
    hashing_test.go:164: 
        	Error Trace:	hashing_test.go:164
        	Error:      	Not equal: 
        	            	expected: "abc1234"
        	            	actual  : "def5678"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-abc1234
        	            	+def5678
        	Test:       	TestSetKubernetesObjectHash

I think it's because the hash label already exists on the old object, so we are overwriting the new hash label in labelsToAdd within this loop

                        for _, k := range labels.MapKeys() {
				v := labels.MapIndex(k)
				labelsToAdd[k.Interface().(string)] = v.Interface().(string)
			}
			labels.Set(reflect.ValueOf(labelsToAdd))

https://github.com/Yelp/paasta-tools-go/blob/master/pkg/hashing/hashing.go#L70

Recommend Projects