yelp / salsa Goto Github PK

Following the directions here: README Link

I get this output upon running generate_sketch:

Fatal error: Could not find font: SFProText-Semibold: file /Users/~/Developer/salsa/SalsaCompiler/SalsaCompiler/SketchJson/Text+SketchJson.swift, line 76
./generate_sketch: line 19: 10945 Illegal instruction: 4  ../SalsaCompiler/build/Release/salsa -f /tmp/SalsaExample/generated.salsa -e ExampleSketch
Failed to build sketch file

I'm wondering if this is because of version mismatch? I had to update generate_sketch's first xcodebuild command. I changed the simulator to iOS 11.3, since Xcode 9.3 does not support the 10.3.1 simulator.

Versions:
xcodebuild: 9.3
Cocoapods: 1.5.0

Swift 4 introduced Codable / Decodable which probably means we don't need to make our own protocol for this anymore

First of all, thanks for the hard work!

Would like to know your opinion on adding new set of APIs to Salsa for capturing UIView instance conveniently. Seems like the current code forces us to instantiate new UIView instances and return them via static function:

static func artboardElements() -> [[ArtboardElement]] 

One usecase of this is to allow it to snap views during the UI automation. I experimented with it to generate Sketch file as visual documentation of an app (removing filtering/purging to keep exact copy of view hierarchies).

The additional APIs could be something like what I did there:
https://github.com/aunnnn/salsa-AutoSketch/blob/master/Salsa/Salsa%2BAutoSketch.swift

Its giving pod installation error like below,

Analyzing dependencies
[!] Unable to find a specification for Salsa

[!] Automatically assigning platform ios with version 11.3 on target Salsa because no platform was specified. Please specify a platform for this target in your Podfile. See https://guides.cocoapods.org/syntax/podfile.html#platform.