yeohhq / pe Goto Github PK

Original state: Aaron is already present, hence 'flagatt 1' does not 'flag' him out. (i.e. he is not 'flagged')

Input: unflagatt 1

Output: Aaron was unflagged despite originally not being flagged, and his attendance has also changed to 'absent', not sure if this was the intended use of 'flag'?

Reference:

UG description suggests that you should only be able to unflag a student that was successfully 'flagged'.

This issue is a feature flaw about the 'delstudent' command.

Input:
delstudent grp/g04 name/david chong matric/A0123456D
(there are multiple whitespaces between 'david' and 'chong' above, but CATcher seems to not be able to display it)

Output:

Rationale:
Perhaps parser should be able to parse individual strings in the name input to match despite there being whitespaces in between as your other commands seem to be able to handle inputs with unnecessary whitespaces.

In this case, the input should match student at index 4.

Since it was already mentioned at the beginning who the System and Actor are, perhaps there is no need to reiterate them for every single use case since it makes the documentation quite long with so many use cases.

Input: flagatt 1

Output:

Suggestion:
Perhaps it would be good to add into the UG for this command that a student must be absent for the 'flagatt' command to work as a command pre-requisite.

Input: addscore 1 score/5

Output:

Suggestion:
Perhaps it would be good to indicate in the UG that a student must be present before the 'addscore' command can be used on them.

This issue is about a feature flaw for 'markabsent' command.

Input: markabsent name/Aaron Tan matric/A0123456A

Output 1 (first time using input above):

Output 2 (second time using input above again immediately after Output 1):

• Yields the exact same screen where Aaron Tan's attendance is marked as absent again.

Rationale:
Perhaps it there should be an exception thrown where the application handles cases where the user tries to update the existing student's attendance when they are already of the same attendance status. (i.e. if already 'absent', inform with an exception such as " with is already marked as absent!")

This issue is about a functionality bug where marking the attendance using 'markpresent all' and 'markabsent all' does not update the UI student attendance list once command is input.

Input: markabsent all

Output:

Rationale:
The output should show all students attendance to be false since the result display already shows 'Attendance of all students marked absent!'.

This issue reports a feature flaw/suggestion where I believe it would be logical to accept a larger range of values for the lesson number for 'addlsn' command.

Input: addlsn grp/g04 lsn/00-10

Output:

Rationale:
For the lesson number, perhaps it should be able to accept numbers with more than one digit (e.g. if the tutor is conducting multiple lesson throughout the current week for different teams).

Input:
addqn qn/.
delqn 1
editqn 1

Output:

Rationale:
Question does not exist, hence it should throw the correct error for invalid question to edit!

The DG formatting is a little off as the text is cut off on the right hand side (line after 'Guarantees: ..."), this occurs for more than one of the use cases at the bottom of the DG.

This issue reports a feature suggestion for the 'addlsn' command.

Input: addlsn grp/g04 lsn/00-1

Output:

Rationale: I believe that the UG uses 'XX-Y' seen below, which the application shows the correct error message, but '00' would probably be better to translate into just '0', or should not be accepted if lessons should start naming from index 1.