yields / editable Goto Github PK

1. Select text
2. Click insert image
3. Click cancel on the dialog

Expected: No change.
Actual: Selected text is deleted.

I followed the directions to install editable -- twice -- and still cannot get past the console error in Safari: Error: failed to require "k" while trying to view the demo page. I have tried manually installing yields/k and also (in a new directory) not doing that -- just in case. I am not sure how to resolve this. Can anyone help?

Thanks,

Walter

somehow

just checked out the online demo, didn't check master. got this error in safari 7:

Hey!

I am trying to integrate the editable functionality and have a question regarding the noramlization, because I want rather to use a <div> for new lines.

What part handles the enter keydown? I couldn't find it :(

Cheers.

google docs does this i suppose, annoying since currently it's a character by character undo.

Reproduce bug:

1. Open demo in Google Chrome
2. Write few lines of text
3. Select some of these lines and convert to UL/OL
4. Click the same button again

You will end up with completely different markup including SPAN inline styles which is especially undesired.

Before executing step 3:

After step 4:

Observation:
Noticed that when you run your mouse over title controls, the following is unnecessarily appended to start of description.

What should happen:
Nothing should be pre-pended on title.

Reproduce:

• load page.
• run mouse over 'B' control
• mouse-over title shows the following, '⌘ + b'
• view source reveals 'title='⌘ + b''

Potential source:
checking the source in index.html noticed the following embedded in the page ''⌘ + b". This could be client side not being able to recognise the symbol.

On your demo, if I only type one letter I can't actually undo that letter input. This isn't very obvious right now because editable saves so frequently. But I'm attempting to patch that right now -- to provide a delayed 'change' such that the history is only updated after 500ms of inactivity by the user -- and it becomes much more evident.

It also seems to push to history some invisible changes, such that calling undo doesn't actually appear to do anything.

with a range as argument

yields/colorpicker

Undo is a little bit funky and not like other editors

steps:

1. select a word
2. hit bold
3. unselect (click at end of word)
4. undo

editors like google docs select the range you bolded, while editable will just place the cursor at the end.

make it async

Steps to reproduce:

1. Edit the document
2. Use the undo keyboard shortcut for your OS
3. Watch the cursor move to the beginning of the document
4. Type to see that the cursor did in fact move

I'd expect the cursor to not move.