Giter VIP home page Giter VIP logo

Comments (4)

moorscode avatar moorscode commented on June 19, 2024 2

I looked into it and it turned out I missed a bit of thinking.
It seems that the travis build is optimized already.

from yoastcs.

jrfnl avatar jrfnl commented on June 19, 2024 1

Side-note: something else which you may or may not want to address in this ticket:

The travis build for YoastCS itself uses the master branches of WPCS as well as PHPCompatibility to test the code style of the YoastCS code.
Those master branches are not necessarily the same as the versions defined in the composer.json file.
This could be synchronized by removing the git clones from the Travis script in favour of doing a composer install.
This will make the builds a little slower.

On the up-side: leaving things as they are, will mean that YoastCS has an "early warning" system in place for when the rulesets need updating.
In that case, it may be useful to configure a regular (monthly?) build in TravisCI to auto-run the build check independent of PRs.

from yoastcs.

moorscode avatar moorscode commented on June 19, 2024

I would suggest to keep that in place and just make sure that we only configure and load elements in the script that are really needed for specific builds instead of altering the builds that are being run.

from yoastcs.

jrfnl avatar jrfnl commented on June 19, 2024

@moorscode I'm not sure I understand what you mean ... ?

from yoastcs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.