Giter VIP home page Giter VIP logo

Comments (3)

Yomguithereal avatar Yomguithereal commented on June 26, 2024

Hello @krom-xr. Normally, a Baobab tree is not supposed to hold anything but raw data, not DOM elements. However this case seems quite strange indeed. I think the tree tries to deep clone the element and stumble upon cyclic references and such. If you really want to do that, you can try turning off the persistent option of your tree. I guess this should fix this use case:

let example = new Baobab({test: {}}, {persistent: false});

from baobab.

krom-xr avatar krom-xr commented on June 26, 2024

Ok. Thanks.
But may be best solution - throw error in that case. If it possible?

In may case -
I put stream (webrtc stream) to Baobab store.
In one option i put canvas.captureStream() (empty stream).
There was ok in chrome - but infinite loop in firefox.
Because stream instance - have link to canvas in firefox.

    CanvasCaptureMediaStream {
​​        active: true
        canvas: <canvas id="webrtc-empty-video" hidden="">
        currentTime: 5.358
​        id: "{dfb95857-2aa8-b14e-a239-bb14cdda3ef6}"
        onaddtrack: null
        onremovetrack: null 
       ...
    }

Thanks for answering. Now i solve my problem. But may be other users can fall into similar situation

from baobab.

Yomguithereal avatar Yomguithereal commented on June 26, 2024

But may be best solution - throw error in that case. If it possible?

Probably so. But checking for circular reference does have a performance cost.

You should really avoid storing classes from the DOM in a Baobab tree if you can, though.

from baobab.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.