yonatanmgr / mathberet Goto Github PK

Describe the bug
When a user resizes the app window, the structure of the file components' location changes (as it should be), but when trying to resize the window, the components won't go back to the same state.

To Reproduce
Steps to reproduce the behavior:

1. Go to one of the files
2. Resize the window
3. Resize it back
4. See the issue

Expected behavior
The components should change according to the size of the window, and change back to the same state when resizing back.

Screenshots

Desktop (please complete the following information):

• OS: macOS (But also happens on Windows)

Additional context
Maybe we should keep the 6 possible states of the components' locations, and then apply them every time a user resizes the window.

Description:
After clicking 'Save' for a particular file, it saves in a Windows-like configured path, even though I run on macOS.

Reproduction:
Simply open a New Folder in the app, and a New File within. After saving it, you'll discover New File is saved outside of New Folder, with the name "files\New Folder\New File.json". Its path: "/Users/<user>/Documents/Mathberet/files\New Folder\New File.json"

Expected behavior:
File path should have its backslashes reverted.

Screenshots:

• OS: macOS

Describe the bug
Error message appears when closing by clicking the upper-right corner 'x'.

To Reproduce
Steps to reproduce the behavior:

1. Create, edit, and save a file.
2. Close the application by clicking the 'x' in the upper-right corner of the window.

Expected behavior
Close application.

Screenshots

Desktop (please complete the following information):

• OS: Windows 11 Home.

Additional context
Cloned and installed today, so the mathberet version is fresh.

It would be really helpful to have an short introduction video (loom?) for eaiser onboarding to the project.

Things that can be covered:

• Project high level folders structure
• Quick app overview
• etc.

Resizing blocks on react-grid-layout doesn't play nice with RTL layouts;
Multiple issues were opened on the subject in react-grid-layout and did not get enough attention.
Maybe a bespoke solution could fit here, forking rgl and making an RTL fix

Describe the bug
When I run the app I get a libva error message. The app still opens, though, and when I try to create a folder, the app crashes.

To Reproduce

1. In a terminal pointed to the install directory, run npm start.
2. When the app opens, click the notepad icon and the new folder icon.

Expected behavior
New folder.

Screenshots

Desktop (please complete the following information):

• OS: Ubuntu 22.04.2

Additional context
I installed npm in order to install this application, but believe I have a correct installation of npm version 9.5.0 and node version v18.15.0. I could be wrong, I'm not very familiar with these packages, so I can try out any terminal commands that might be helpful, but these print out the version numbers that I've shown here with npm --version and node --version.

I tried installing libva either through npm or apt-get and neither could find the package.

An option to encrypt certain files (lock them), and decrypt them by using a chosen password (a key).
When a user tries to open an encrypted file, a password input modal will be prompted.

Possible library:
https://www.npmjs.com/package/crypto-js

Something like that:

As Kbar's actions are only rendered once (on app startup), i18n language changes won't affect them.
Kbar does have a hook named useRegisterActions that could help with updating the actions on dependencies change, but it doesn't seem to work (and isn't well documented timc1/kbar#164).

FilePath component in src\renderer\components\Header\FilePath.tsx:
When working on macOS, the folder path is not separated properly, displaying the full path

As title says, if the user has no files or folders in .../Documents/Mathberet/files, an error pops up and files can't be created

Right-clicking on block handles could bring out a context menu with the abovementioned actions

I suggest we add Storybook to the project. Storybook is a user interface development environment that allows us to build, test, and showcase our UI components in an isolated, reusable environment.
It will significantly improve collaboration, and will help keeping unified design language across the entire app.
I started testing it locally, and so far, it seems suitable for this project.

I'm thinking of something like this:

• When the user inputs a $ followed by a space, an editable MathLive component will be created as an inline slate element with a dynamic width (long shot but maybe?). Another option is to have a popup for the math input, then pressing Enter will insert an inline slate element (that is not directly editable).
• When the user inputs a $$ followed by a space, an editable MathLive component will be created as an block level slate element.

Describe the bug
Dragging file into a folder that already have file with that name doesn't raise error. Instead, it shows that there are 2 files with the same name under that directory. In the actual file system, the file that was dragged is vanished, and there is only one file in that name under that directory.

To Reproduce
Try to drag a file into a directory that already has a file with that name.

Expected behavior
An error modal should pop up, and the dragged file should stay at it original location.

Desktop:

• OS: Windows