Giter VIP home page Giter VIP logo

example-element's People

Contributors

dasdeck avatar forrestkirby avatar hannazn avatar hendrikbehncke avatar janschoenherr avatar miljan-aleksic avatar saschadube avatar steffans avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

example-element's Issues

Unclear what the purpose of content.php is

The docs and the readme here don't make clear what the new content.php is for. It seems to be a duplicate of part of template.php... but I have no idea what I'm supposed to do with it. It's never mentioned in the docs or in the readme except that it "renders the content which is saved in the page"... but what's the difference between that and rendering "the actual front-end markup"?

element.php updates hook not working?

I created a custom builder element following the docs, and recently wanted to rename one of my props, so I added an 'updates' hook like this to the element.php file in the custom element's directory do so:

<?php

return [

    'updates' => [

        '1.1.2' => function ($node, array $params) {

			if (isset($node->props['tag_slug'])) {
				$node->props['filter_tag_slugs'] = $node->props['tag_slug'];
				unset($node->props['tag_slug']);
			}

        },

    ],

];

However when I load pages that already had the custom element on them (with a value in the old prop named tag_slug, they don't get seem to be getting the new prop name. It seems this hook isn't firing at all. What am I doing wrong?

The 1.1.2 version number is my child theme's version number, but I assume that part doesn't matter?

I'm running Yootheme 1.20.6 as the parent theme.

Hard coded child theme name

I've created child theme as discribed in docs.

My child theme folder is yootheme_vbik
image

So I created builder folder in child theme and extracted this repo in it

So my structure looks like this:
image

But if I'll try to create new element - I don't see any icon on it
_583

And in console I see wrong way to SVG icon
image
the true way is .../templates/yootheme_vbik/builder/pro-element/icon.svg

So, how to fix it?

reflect expression conversion limitations

Thank you wf!
Unfortunately, your component exceeds the limitations of our migration script.
We will update the documentation and script to reflect those limitations.

The problem is with the functions in the enable (and show) fields. Our script attempts to convert those to the new expression syntax, though it will fail with more complex examples. I'll change the script to not throw an exception, but instead, log helpful warnings to migrate those fields manually after the conversion.

Cheers!

JM

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.