youngchan1988 / json_editor Goto Github PK

When the contents of the json editor are emptied, the onValueChanged function is not getting triggered

Thank you for the great package. It works perfectly fine when dealing with the English language.

It would be great if you can take some time from your busy schedule to add support for this feature. Or you can point me to some direction so I can implement it myself and create a pull request.

When JSON contains the Khmer language it doesn't parse and format the string.
I looked into the code and found out that the package only deals with English Unicode only. It would be great if you can add the language support for Khmer as well so it parses and formats the Khmer language just like it does with English.

See the attached examples.

Example 1:
At the end inside verb it ends with double closing curly bracket } whereas there should be only one. Also when editing the closing curly bracket } after def key value, it can't be deleted.

Here is the JSON so you can test it.
{
"uid": "61ea4987851f4038c8fcfb26",
"hw": "put a stop to",
"syllable": [
{
"syl": "put a stop to"
}
],
"fl": "v.",
"verb": [
{
"def": "ដាក់ការបញ្ឈប់ទៅ។ "
}
],
}

Example 2:
In this example, there should be a closing square bracket and a closing curly bracket. But there is not and the editor is not throwing any error.

Here is the JSON so you can test it.
{
"uid": "61ea4987851f4038c8fcfb23",
"hw": "put a flea in one's ear",
"syllable": [
{
"syl": "put a flea in one's ear"
}
],
"fl": "v.",
"verb": [
{
"def": "ផ្លុំត្រចៀក; និយាយរញ៉ាំរញ៉ូវ; ទន្ទេញទន្ទូររឿយៗ។ "
}
],
}

Here is the Unicode specification for Khmer language

https://unicode.org/charts/PDF/U1780.pdf

Sharing what I searched and found

I want to support the Khmer characters listed in the table below
CHARACTER TO UNICODE, CONVERSIONS
I think you'll be mostly interested in Decimal values, as this is what you're using for english.

I think the package needs to accept null as a valid value and have its own style.

Hello
There is a problem when I try to parse such json:

{
  "array": [
    {
      "first_child": [
        {
          "text": "First item"
        },
        {
          "text": "Second item"
        }
      ],
      "second_child": [
        {
          "text": "First item"
        },
        {
          "text": "Second item"
        }
      ]
    }
  ]
}

I checked this json in JSON Editor Online and it's worked. But the JsonEditor widget show:
"Syntax error: Invalid ',' at line 7 position 94".

Hello, at the first I should say thanks for your awesome repo
Anyway I have some issue with that

1. Why did you use logger package for validating data this is very annoying. Please add an options to disable that

2. There is some delay to update value in onValueChanged
   for example I write this json and after that immediately press a button:
   
   but I get this json as JsonElement:

{
    "test": ""
}

3. When I try to add jsonString with a comment the comment does not display:

JsonEditor.string(
  jsonString: '''
  {
      // Insert your data here
  }
  ''',
  enabled: true,
  onValueChanged: (value) {
    document = value;
  },
),

When editing the text, there is a delay of 1sec since the text was changed to when the onValueChanged callback is triggered.

There should be a way to disable that.

First of all I want to say THANKS for the great package :)

I thing it would be great if we could have line number in this package. I would contribute if I could :)

I am using this editor in a StatefulWidget to display a JSON string. When updating the state of the widget with the new JSON string the editor is not changing. I checked your code, the editor is only intended to update itself when not enabled.