Fix linting issues about youpin-bot HOT 10 OPEN

@iswanj Go for it

from youpin-bot.

This repo still uses console a lot. So, I think you can disable it in .eslintrc for now. We may refactor it later.

from youpin-bot.

@supasate I'll take this

from youpin-bot.

@supasate I found lint issue in messenger.js. There is lint rule for no-console, so I can dissable lint warn for these specific lines. or is there any other solution ?

if (!error && response.statusCode === 200) {
    console.log('Successfully sent generic message ' +
            `with id ${body.message_id} to recipient ${body
body.recipient_id}`);
} else {
    console.error('Unable to send message.');
    console.error(response);
    console.error(error);
}

from youpin-bot.

@supasate

refreshToken() {
    // TO-DO: Call /token/auth/refresh instead
    const app = feathers()
      .configure(hooks())
      .configure(rest(this.uri).superagent(request))
      .configure(authentication());

    new Promise((resolve, reject) => {
      app.authenticate({
        type: 'local',
        'email': this.username,
        'password': this.password
      }).then(result => {
        this.token = app.get('token');
        resolve(this);
      }).catch(error => {
        console.log(error);
        reject(error);
      });
    });
  }

Inside refreshToken function, getting an eslint warn for "no-new" ( Do not use new for side effects ). So I'm gonna ignore "no-new" rull, any thoughts...?

from youpin-bot.

Also found another error "Fatal Parsing error: Unexpected token" on
let context = await (conversation.getContext(userid));
on this line

from youpin-bot.

@iswanj The "no new for side effect" warning is there because wrapping the call to app.authenticate in a promise is useless (as app.authenticate already returns a Promise, plus the resulting promise is unused). The code could be written like this:

app.authenticate({
  type: 'local',
  'email': this.username,
  'password': this.password
}).then(result => {
  this.token = app.get('token');
}).catch(error => {
  console.log(error);
});

from youpin-bot.

@iswanj For parsing error of await, you can eslint-disable-line.

The reason is we use asyncawait which async and await are functions that take another functions as arguments. (They just make them look alike keywords but they are, literally, functions).

That's different from async and await in ES7 which are keywords.

Therefore, eslint expects the following ES7 format:

onMessaged: async (event) => {
  ...
  await conversation.getContext(userid)
}

We may refactor it later when we move to ES7.

from youpin-bot.

@supasate I think eslint-disable-line is working for the rules only.

from youpin-bot.

You're right. So, I think we can left it unless we find a workaround.

from youpin-bot.