youyuanwu / winasio Goto Github PK

More details: https://learn.microsoft.com/en-us/windows/win32/http/versioning-in-http-2-0

• Migrate HttpAddUrl
  Currently winasio is using HttpAddUrl:

HTTPAPI_LINKAGE ULONG HttpAddUrl(
  [in] HANDLE RequestQueueHandle,
  [in] PCWSTR FullyQualifiedUrl,
       PVOID  Reserved
);

but https://learn.microsoft.com/en-us/windows/win32/api/http/nf-http-httpaddurl
says

Starting with HTTP Server API Version 2.0, applications should call [HttpAddUrlToUrlGroup](https://learn.microsoft.com/en-us/windows/desktop/api/http/nf-http-httpaddurltourlgroup) to register a URL; HttpAddUrl should not be used.

• Migrate https://learn.microsoft.com/en-us/windows/win32/api/http/nf-http-httpcreatehttphandle to HttpCreateRequestQueue

http_connection, winnet::http::simple_request and winnet::http::simple_response are exposed for ease of use for a server application.
Currently http server to user logic is handled by a handler function:

We need to improve and finalize this API.

One example of high level API is this: https://github.com/nghttp2/nghttp2-asio
https://www.nghttp2.org/documentation/libnghttp2_asio.html

Right now the body is always read 10 bytes at a time.

We should let the user pass a hint to how long the body would be, and read it at once.
Or explorer if there is a way to query the body length in kernel before reading.

Currently the high level API is:

Which is based on winnet::winhttp::payload, and require user to supply every arg.

This API layout needs to be finalized.

shutdown the request queue first and then shutdown the asio io service.
Use this function: https://learn.microsoft.com/en-us/windows/win32/api/http/nf-http-httpshutdownrequestqueue

Provide functionalities to read http trailers

There are various debug boost log lines all across the implementation files, and it is useful for debugging while developing this lib.
When doing benchmarks, such logs may degrade performance even though the log filter is specified.

So debugs should be macro-ed out our wrapped in #ifdef lines.

When there are high number of connections, the requests are slow and some connections timed out.
Maybe the acceptor loop needs to limit the max accepted connections.

Error is not yet handled in the callback:

Case WINHTTP_CALLBACK_STATUS_REQUEST_ERROR needs to be added and callback needs to be invoked with error code.