ypeckstadt / hyperledger-composer-rest-server Goto Github PK

Due to time constraints and slapping this code together quite fast, I forgot a few important features.

Currently I am not closing the business network connection after every connect

I need to call businessNetworkConnection.disconnect() at the end of every promise chain.

In the gulpfile.js, version 3 gulp is used i mean syntax of gulp 3 but the packages specifies that gulp 4 .
either update the code in gulpfile.js or degrade the version.

thanks in advance

Revoke identity when deleting a driver is missing.

The id here is a unique ID that is returned when issueing a new identity. It is not the driver id-email. It is a UUID.

Needs to be stored in the passport-token or driver data so it can be accessed on deletion.

composerConnection.bizNetworkConnection.revokeIdentity(id)

Due to time constraints and slapping this code together quite fast, I forgot a few important features.

When creating a driver a new identity needs to be registered and the id card needs to be imported.

   // issue a new identity by composer-client
        const identity = await composerConnection.bizNetworkConnection.issueIdentity(
          composerConnection.composerModelFactory.getNamespaceForResource(ComposerTypes.Driver, payload.id),
          payload.email
        );

        // import new Id card
        await this.connectionManager.importNewIdCard(identity.userID, identity.userSecret);