Giter VIP home page Giter VIP logo

Comments (4)

ysmood avatar ysmood commented on July 16, 2024

Define properties on a promise instance directly is a bad pattern. You have to capsule the callback function into the reason, not the promise itself.

from yaku.

ysmood avatar ysmood commented on July 16, 2024

You don't have to use onunhandledrejection at all:

var SkipError = function () {};

var handleRejection = function (promise) {
  return promise.catch(function (reason) {
      if (reason && reason instanceof SkipError) {
        return;
      } else {
        console.error('MIDDLEWARE ERROR:', reason);
        return Promise.reject(reason);
      }
  });
};

var promise = new Promise(function (resolve, reject) {
  reject(new SkipError());
})

handleRejection(promise).then(function (result) {
    console.log('ok')
});

from yaku.

svsool avatar svsool commented on July 16, 2024

Thanks for the answer, but .catch not suitable for my app. I define properties on a promise directly, because I didn't find another way to pass callback to unhandleRejection in your lib, that customize global onhandlerejection for my superagent promise that used to fetch data throughout the app. In my case, .catch branch prevent calling rejection callback passed to .next in other place of app and I don't want wrap each .then with custom method that catch error if rejection method not passed, unfortunately promise don't have finallyCatch method, that don't prevent calling rejection passed to .then, so I use global handler for that, if rejection handler not passed, I skip it in global onhandlerejection with custom behaviour (through callback in promise), if rejection callback passed, then handle it in .then branch, sorry but it hard to explain. Maybe I can wrap Promise instance in my custom class? But anyway it wouldn't pass to onunhandledrejection directly, because somewhere in the lib it's replaced with another promise.

from yaku.

ysmood avatar ysmood commented on July 16, 2024

Then you may want to use guard: https://github.com/ysmood/yaku#guardtype-onrejected

var Promise = require('yaku');
require('yaku/lib/guard');

class AnError extends Error {
}

Promise.reject(new AnError('hey'))
.guard(AnError, (err) => {
     // only log AnError type
     console.log(err);
})
.then(() => {
     console.log('done');
})
.guard(Error, (err) => {
     // log all error type
     console.log(err)
});

from yaku.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.