Comments (4)
Define properties on a promise instance directly is a bad pattern. You have to capsule the callback function into the reason
, not the promise itself.
from yaku.
You don't have to use onunhandledrejection
at all:
var SkipError = function () {};
var handleRejection = function (promise) {
return promise.catch(function (reason) {
if (reason && reason instanceof SkipError) {
return;
} else {
console.error('MIDDLEWARE ERROR:', reason);
return Promise.reject(reason);
}
});
};
var promise = new Promise(function (resolve, reject) {
reject(new SkipError());
})
handleRejection(promise).then(function (result) {
console.log('ok')
});
from yaku.
Thanks for the answer, but .catch not suitable for my app. I define properties on a promise directly, because I didn't find another way to pass callback to unhandleRejection in your lib, that customize global onhandlerejection for my superagent promise that used to fetch data throughout the app. In my case, .catch branch prevent calling rejection callback passed to .next in other place of app and I don't want wrap each .then with custom method that catch error if rejection method not passed, unfortunately promise don't have finallyCatch method, that don't prevent calling rejection passed to .then, so I use global handler for that, if rejection handler not passed, I skip it in global onhandlerejection with custom behaviour (through callback in promise), if rejection callback passed, then handle it in .then branch, sorry but it hard to explain. Maybe I can wrap Promise instance in my custom class? But anyway it wouldn't pass to onunhandledrejection directly, because somewhere in the lib it's replaced with another promise.
from yaku.
Then you may want to use guard
: https://github.com/ysmood/yaku#guardtype-onrejected
var Promise = require('yaku');
require('yaku/lib/guard');
class AnError extends Error {
}
Promise.reject(new AnError('hey'))
.guard(AnError, (err) => {
// only log AnError type
console.log(err);
})
.then(() => {
console.log('done');
})
.guard(Error, (err) => {
// log all error type
console.log(err)
});
from yaku.
Related Issues (20)
- Only the core works well with old browsers HOT 1
- Something strange (Slow resolve on pageload) HOT 23
- Yaku doesn't work if div with id="process" exists HOT 2
- Can't register global unhandled rejection HOT 1
- Does not work on UC Browser HOT 9
- incorrect behavior with unhandledrejection events HOT 8
- Yaku.all is overridden by yaku/utils/all on yaku.brower.full.min.js version HOT 3
- difference between return Promise.reject(x) and throw x HOT 7
- Finally swallows rejections HOT 4
- Bind to Angular 1.x digest? HOT 6
- Bad references in package.json HOT 1
- 0.18.3 is broken if window.Promise is set to Yaku HOT 3
- Implement Promise.try() ? HOT 1
- Incorrect promise when calling `resolve` twice HOT 1
- global.Promise should be non-enumerable and should have correct name property HOT 5
- "hash" util/helper request HOT 3
- Mock Mode HOT 7
- Support for Promise.allSetteled HOT 2
- Bug: Stealing a resolver and using it to trigger reentrancy HOT 3
- Promise.all and Promise.allSettled doesn't work if the promise array has been created in a different frame. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from yaku.