Giter VIP home page Giter VIP logo

Comments (14)

ysmood avatar ysmood commented on July 16, 2024

Thanks, I'll implement it ASAP.

from yaku.

ysmood avatar ysmood commented on July 16, 2024

ES6 is locked, so it should be a part of ES7 or somehow. I'm sorry that I'm a little outdated.

So I don't know, where to implement it, as an extension or inside the core. I need more information.
I did some research on the internet, nothing seems helpful. I even can't figure out it's ES7 or ES-Next.

from yaku.

JakeChampion avatar JakeChampion commented on July 16, 2024

It's not in ES2016/ES7, only two Math methods were added to ES2016/ES7. It will hopefully enter Stage 3 at some point this year.

Criteria to move to Stage 3:

  • Complete spec text
  • Designated reviewers have signed off on the current spec text
  • The ECMAScript editor has signed off on the current spec text

It is up to you where to implement it. I imagine people would be confused if they had to install Yaku and a Yaku plugin to get ES-Promises working.

from yaku.

ysmood avatar ysmood commented on July 16, 2024

Uh, it should be inside the core.

from yaku.

JakeChampion avatar JakeChampion commented on July 16, 2024

@ysmood Do you need some help with this feature at all?

from yaku.

ysmood avatar ysmood commented on July 16, 2024

Yes, I need some help. The performance is my main concern.

from yaku.

ysmood avatar ysmood commented on July 16, 2024

The two extra closure makes me headache. I may merge the finally branch if I have time to add more test cases.

from yaku.

ysmood avatar ysmood commented on July 16, 2024

@JakeChampion I published the version v0.17.0 with the newly added finally support. Hope its not too late.

from yaku.

JakeChampion avatar JakeChampion commented on July 16, 2024

Thanks!

from yaku.

JakeChampion avatar JakeChampion commented on July 16, 2024

Looks to fail some tests in these browsers:

 • ie/11
 • ie/10
 • ie/9
 • ie/8
 • android/4.4

from yaku.

ysmood avatar ysmood commented on July 16, 2024

May I see the error information?

from yaku.

JakeChampion avatar JakeChampion commented on July 16, 2024

Rerunning the test suite now as I had some configuration errors which reported lots of false positives. Apologies if it turns out everything is working.

from yaku.

JakeChampion avatar JakeChampion commented on July 16, 2024

Tests pass on all except IE8 which seems to hang

from yaku.

ysmood avatar ysmood commented on July 16, 2024

I will double check it later.

from yaku.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.