ysoftwareab / http-lambda Goto Github PK

support multiValueHeaders #5
Closed

[57]andreineculau opened this issue Feb 20, 2019 · 0 comments

Closed
[58]support multiValueHeaders #5
[59]andreineculau opened this issue Feb 20, 2019 · 0 comments

Labels

[60]enhancement [61]wontfix
Comments
[62]@andreineculau

Copy link (BUTTON) Quote reply

Member
[63]@andreineculau [64]andreineculau commented [65]Feb 20, 2019 •
edited
refs

* [66]https://aws.amazon.com/blogs/compute/support-for-multi-value-pa

rameters-in-amazon-api-gateway/

* [67]https://docs.aws.amazon.com/apigateway/latest/developerguide/se

t-up-lambda-proxy-integrations.html#apigateway-multivalue-headers-a

nd-parameters
[68]@andreineculau [69]andreineculau added the [70]enhancement label

[71]Feb 20, 2019

[72]@andreineculau [73]andreineculau added this to To do in [74]Public

(Open Source) via automation [75]May 20, 2019

[76]@andreineculau [77]andreineculau added the [78]wontfix label

[79]May 20, 2019

[80]@andreineculau [81]andreineculau closed this [82]May 20, 2019

[83]Public (Open Source) automation moved this from To do to Done

[84]May 20, 2019

[85]@ankitmth [86]ankitmth removed this from Done in [87]Public (Open

Source) [88]Feb 19, 2020

lodash #1
Closed

[57]andreineculau opened this issue Feb 23, 2018 · 3 comments

Closed
[58]lodash #1
[59]andreineculau opened this issue Feb 23, 2018 · 3 comments

Labels

[60]enhancement [61]help wanted
Comments
[62]@andreineculau

Copy link (BUTTON) Quote reply

Member
[63]@andreineculau [64]andreineculau commented [65]Feb 23, 2018
given the size of lodash, and given the tiny size of the http-lambda

package,

1. lodash could actually become a peer dependency, and decrease the

bundle size in projects where lodash is a dependency anyway

2. remove the dependency on lodash, which would have effects on load

time as well (less js to parse)
My suggestion is to do it in two steps, as listed above

[66]@andreineculau [67]andreineculau added [68]enhancement [69]help

wanted labels [70]Feb 23, 2018

[71]@IanSavchenko
This comment has been minimized.
[72]Sign in to view

Copy link (BUTTON) Quote reply
[73]@IanSavchenko [74]IanSavchenko commented [75]Feb 23, 2018
I agree.

But a question here: if we specify lodash dependency as a regular one

(not peer) something like "^4.0.0", it still won't reuse a project

top-level lodash, because we use "global-style" node_modules checkout

in some repos?

[76]@andreineculau
This comment has been minimized.
[77]Sign in to view

Copy link (BUTTON) Quote reply

Member Author
[78]@andreineculau [79]andreineculau commented [80]Feb 23, 2018
yup. every global-style dep will have its own lodash, plus maybe

another lodash (the root package needs lodash)

[81]andreineculau added a commit that referenced this issue [82]Feb 23,

2018

[83]@andreineculau

[84]turn lodash into a peer dependency. ref [85]#1

[86]0b67d80

[87]@andreineculau
This comment has been minimized.
[88]Sign in to view

Copy link (BUTTON) Quote reply

Member Author
[89]@andreineculau [90]andreineculau commented [91]Feb 16, 2019
should be less of a problem now with semver ranges in place, and with a

slightly optimized lambda dist (i.e. npm dedupe). closing

[92]@andreineculau [93]andreineculau closed this [94]Feb 16, 2019

bump @types/node to ^13.5.1 #6
Closed

[57]andreineculau opened this issue Jan 29, 2020 · 0 comments

Closed
[58]bump @types/node to ^13.5.1 #6
[59]andreineculau opened this issue Jan 29, 2020 · 0 comments
Comments
[60]@andreineculau

Copy link (BUTTON) Quote reply

Member
[61]@andreineculau [62]andreineculau commented [63]Jan 29, 2020
No description provided.

[64]@andreineculau [65]andreineculau added this to To do in [66]Public

(Open Source) via automation [67]Jan 29, 2020

[68]@andreineculau [69]andreineculau closed this in [70]7810128 [71]Jan

29, 2020

[72]Public (Open Source) automation moved this from To do to Done

[73]Jan 29, 2020

[74]@ankitmth [75]ankitmth removed this from Done in [76]Public (Open

Source) [77]Feb 19, 2020

add support for binary (base64) req/res. fix #2 #4
f/anu-binary
master f/anu-binary

@andreineculau

[45]andreineculau opened this pull request about 1 year ago • edited

about 1 year ago
Labels

[46]enhancement

* Fixes: [47]#2

* Breaking change: [ ]

__________________________________________________________________
[48]andreineculau added a commit [49]about 1 year ago

[50]@andreineculau [51]add support for binary (base64) req/res. [52]fix

[53]#2
andreineculau added the [54]enhancement label [55]about 1 year ago
andreineculau self-assigned this [56]about 1 year ago
andreineculau requested a review from IanSavchenko [57]about 1 year ago
@IanSavchenko

[58]IanSavchenko approved these changes [59]about 1 year ago
andreineculau referenced this pull request from commit [60]eb5f285

[61]about 1 year ago
andreineculau merged commit eb5f285 into master [62]about 1 year ago
andreineculau deleted the f/anu-binary branch [63]about 1 month ago

add basic tests #3
f/anu-test
master f/anu-test

@andreineculau

[45]andreineculau opened this pull request

about 1 year ago
Labels

[46]enhancement
in order not to be surprised by upcoming nodejs upgrades like in

[47]tobiipro/aws-util-firecloud@0e4f9b0
[48]andreineculau added a commit [49]about 1 year ago

[50]@andreineculau [51]add basic tests
andreineculau added the [52]enhancement label [53]about 1 year ago
andreineculau requested a review from IanSavchenko [54]about 1 year ago
[55]andreineculau added some commits [56]about 1 year ago

[57]@andreineculau [58]add test for merging ctx.env

[59]@andreineculau [60]add test for requestContext

[61]@andreineculau [62]add test for exposed methods and status codes
@IanSavchenko

[63]IanSavchenko reviewed [64]about 1 year ago
Regarding linter comments:

1. In the places where you are disabling jest/prefer-strict-equal

couldn't you use toMatch and toMatchObject?

2. Had this question before: why do we have the rule

jest/no-test-callback? What's wrong with that? I read the rule

description, which says that people forget to call done in

scenarios when test fails. But if that happens test will fail

anyway with timeout. Otherwise, I see no harm using done when you

are testing callback-based APIs and don't want to convert to

promises (like you have here)
Copy link

@andreineculau

[65]andreineculau

commented [66]about 1 year ago

1. good that you ask, because i was going to ask you if we should turn

the rule off. i didn't know about toMatchObject but reading the

docs [67]https://jestjs.io/docs/en/expect.html#tomatchobjectobject

it's not equivalent. because toEqual will fail if you have more

props than what you expect, or so i think. i think we should have

it off in the preset, at least based on the experience these days,

since you cannot use toBe for non-primitives most of the times

2. i took it as "we prefer async-await pattern vs callback" on top of

what the rule description says. with async taking over cb, i think

it makes sense to keep it. wdys?
Copy link

@IanSavchenko

[68]IanSavchenko

commented [69]about 1 year ago

1. I also didn't know about toEqual gotcha with extra keys not

considered a difference. I thought that it was your intention to

use this and have matching behavior instead of strict equality and

you didn't know about toMatchObject. This rule makes some sense, so

I would probably keep it. But I don't understand why you had to

disable it in these cases? Because there were keys with undefined

values in resulting objects?

2. Ok, let's keep it.
Copy link

@andreineculau

[70]andreineculau

commented [71]about 1 year ago
 I also didn't know about toEqual gotcha with extra keys not
 considered a difference.

just for clarity:

* toEqual: exact deep structure

* toMatchObject: subset deep structure
It's toMatchObject that will not fail on extra keys.

__________________________________________________________________
the rest,... I'm ... I didn't know about

toStrictEqual. I guess I didn't read the rule description, because I

thought it's telling me to use toBe thus my previous comment:
 since you cannot use toBe for non-primitives most of the times

[72]andreineculau added a commit [73]about 1 year ago

[74]@andreineculau [75]use toStrictEqual
Copy link

@andreineculau

[76]andreineculau

commented [77]about 1 year ago
Done. THANKS!

👍 1

IanSavchenko reacted with thumbs up emoji
andreineculau self-assigned this [78]about 1 year ago
[79]andreineculau added some commits [80]about 1 year ago

[81]@andreineculau [82]travis builds only master and PRs

[83]@andreineculau [84]travis: build also version tags

[85]@andreineculau [86]updated support-firecloud

[87]@andreineculau [88]updated support-firecloud
@IanSavchenko

[89]IanSavchenko approved these changes [90]about 1 year ago
andreineculau referenced this pull request from commit [91]b3fca7d

[92]about 1 year ago
andreineculau merged commit b3fca7d into master [93]about 1 year ago

support binary responses (maybe requests too?) #2
Closed

[57]andreineculau opened this issue Mar 5, 2018 · 0 comments

Closed
[58]support binary responses (maybe requests too?) #2
[59]andreineculau opened this issue Mar 5, 2018 · 0 comments

Labels

[60]enhancement
Comments
[61]@andreineculau

Copy link (BUTTON) Quote reply

Member
[62]@andreineculau [63]andreineculau commented [64]Mar 5, 2018
this revert commit [65]f04a738
happened because binary content-types need to be manually marked in API

gateway
Ref:

[66]https://docs.aws.amazon.com/apigateway/latest/developerguide/api-ga

teway-payload-encodings-configure-with-console.html

[67]@andreineculau [68]andreineculau added the [69]enhancement label

[70]Mar 5, 2018

[71]andreineculau added a commit that referenced this issue [72]Feb 16,

2019

[73]@andreineculau

[74]add support for binary (base64) req/res. [75]fix [76]#2

Verified

This commit was signed with a verified signature.

[77]andreineculau Andrei Neculau

GPG key ID: 79FA7EE650BF9A61 [78]Learn about signing commits

[79]df7f8b0

[80]andreineculau added a commit that referenced this issue [81]Feb 16,

2019

[82]@andreineculau

[83]add support for binary (base64) req/res. [84]fix [85]#2

Verified

This commit was signed with a verified signature.

[86]andreineculau Andrei Neculau

GPG key ID: 79FA7EE650BF9A61 [87]Learn about signing commits

[88]36fbd4c

[89]@andreineculau [90]andreineculau mentioned this issue [91]Feb 16,

2019

[92]add support for binary (base64) req/res. fix #2 #4

Merged

[93]@andreineculau [94]andreineculau closed this in [95]#4 [96]Feb 19,

2019

[97]andreineculau added a commit that referenced this issue [98]Feb 19,

2019

[99]@andreineculau

[100]Merge pull request [101]#4 [102]from tobiipro/f/anu-binary

(BUTTON) …

Verified

This commit was created on GitHub.com and signed with a verified

signature using GitHub’s key.

GPG key ID: 4AEE18F83AFDEB23 [103]Learn about signing commits

[104]eb5f285

add support for binary (base64) req/res. fix [105]#2