yuangli / idm221 Goto Github PK

Issues

1. Not sure if your GitHub repository is up to date. The last push was 18 days ago (as of December 15, 2017) and the HTML code does not seem to match your live website.
2. HTML errors (view the error report)
3. One CSS error
   
4. Anchor links do not work. Your href values include capital letters (<a href="#Gallery">), but the target element id is lower case (<div id="gallery" name="Gallery">). It is the id attribute, not the name attribute that manages the links on the same page.
5. The layout concept is interesting, but it's not structured properly. The overlaid text is not positioned consistently. I suspect on your system it looks perfect, but if you look at the site on a larger screen, all of the overlaid text appears off center, sometimes totally in a different position from the parent element.
6. The contact information all being an image instead of HTML is lazy. User can't click on the phone number or email address, can't copy/paste the text. Screen readers can not access the information and the typeface doesn't match the rest of the site.
7. The resume content should be programmed in HTML. The .pdf is okay as a supplement to the HTML content, but it should not be the only way the content is delivered.
8. You're using <a> tags instead of <p> for your project descriptions. This is bad form because the content is not an anchor and shouldn't be structured as one, and if you are going to use an anchor, there has to be an href so that when the link is clicked, it does something.

<a>A digital game group project. We made a game that resembled Atari’s 
1979 Asteroids but create a new way to play. The Game controls randomly 
change in the beginning of every level, which is 40 seconds per level. 
The key swaps will occurs at the end of each round. We used GameMaker 
for game mechanic and 2D Artwork for visual element. Together, we 
designed the user interface, animated elements, game mechanics, etc. 
The game's trailer is down here. Feel free to view it.</a>