[joyop & smoother] full stop vs. slowing down about yujin_ocs HOT 7 CLOSED

Before diving into implementation details, I like to review the desired behaviour:

1. Deadman button released -> immediate stop (safety feature)
2. Deadman button pressed & stick at zero-position
   1. User released the joystick -> slow down
   2. User took over control from navigation -> full stop
3. Optional: Brake button pressed -> full stop (safety feature)

I would like to avoid adding more buttons, since we are already running low one them (and the high-speed mode (#99) will use another one). However after thinking about the above cases I don't know how to implement it cleanly without (case 1. vs. 2.i. above).

Regarding the implementation I'm considering add a second publisher to joyop, which sends out a message when

1. The deadman button has been released after being pressed. OR
2. The brake button is pressed.

Thoughts?

from yujin_ocs.

Regarding that publisher, for Gophers we could either use the emergency stop (an empty message sub) or another cmd vel publisher, which sends its message to a "unsmoothed" topic.

I will put up an implementation for the latter, since it should be more general.

from yujin_ocs.

The problem with the clean implementation is that if there is navigation running and you want to do a full stop, it will only full stop for a little bit before the navigation might kick in?

from yujin_ocs.

If you want to force a full stop during navigation you would need to keep the deadman pressed to take over control and then the brake until its stops. Navigation will not be able to take over again until the deadman is released.

If you just press the deadman (as we do currently) the robot will slowly come to a halt (as defined by the deceleration factor).

All this assuming the user is not touching the joystick.

from yujin_ocs.

I don't like that.

Is there a problem with the brake always being pushable without the deadman?

from yujin_ocs.

Added your suggestion. Brake can now always be triggered - independent of the motors being enabled or the deadman button being pressed.

from yujin_ocs.

Implemented by f23f009.

from yujin_ocs.