Giter VIP home page Giter VIP logo

Comments (5)

yuphin avatar yuphin commented on August 28, 2024

Since both is_specular() and is_diffuse() have use cases in shaders, there exists a range of materials in between those two. So we just call them Glossy instead of something like NotSpecularNorDiffuse. Plus, it might have some other use cases in the future as well.

from lumen.

tigrazone avatar tigrazone commented on August 28, 2024
// BSDF Props
#define BSDF_FLAG_DIFFUSE 1 << 0
#define BSDF_FLAG_SPECULAR 1 << 1
#define BSDF_FLAG_GLOSSY 1 << 2
#define BSDF_FLAG_REFLECTION 1 << 3
#define BSDF_FLAG_TRANSMISSION 1 << 4

i.e. BSDF_FLAG_GLOSSY not used in shaders

from lumen.

tigrazone avatar tigrazone commented on August 28, 2024
#define BSDF_FLAG_LAMBERTIAN 1 << 5
#define BSDF_FLAG_DISNEY 1 << 6
#define BSDF_FLAG_FROSTBITE 1 << 7

also not used and can be removed

from lumen.

tigrazone avatar tigrazone commented on August 28, 2024

is ok to define
#define BSDF_FLAG_GLOSSY BSDF_FLAG_DIFFUSE | BSDF_FLAG_SPECULAR | BSDF_FLAG_REFLECTION
or better
#define BSDF_FLAG_GLOSSY BSDF_FLAG_ALL
?

from lumen.

yuphin avatar yuphin commented on August 28, 2024

I've removed those flags. I think it's fine to have a separate glossy flag.

from lumen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.