yuriiik / isvimagescrollview Goto Github PK

This is not a real issue so feel free to delete it.

I just wanted to say thanks.
I was having a really frustrating day trying to get this pinch/zoom/pan in a scrollview thing to work using constraints. I had it mostly working but there was always something weird with the content size or position, especially after rotating the screen. All the "tutorials" on how to do it were overly simplistic and didn't actually work very well.

I decided to try your code out and it worked perfectly. I adapted to work with any kind of UIView (as long as you pass an explicit aspect ratio) and it has worked great. Really saved my sanity!

Anyway, I tried looking you up on Twitter and I just saw that you're from Kiev. I hope you and your family are safe and are doing as well as you can, given the circumstances.

Take care dude and thanks again

I get the occasional crash:

[ISVImageScrollView scaleImageForScrollViewTransitionFromBounds:toBounds:]
*** Terminating app due to uncaught exception 'CALayerInvalidGeometry', reason: 'CALayer position contains NaN: [nan nan]'

I think the line 101:

CGSize containedImageSizeOld = [self rectSizeForAspectRatio:self.imageAspectRatio
thatFitsSize:oldSize];

might be returning a zero size and further down the line, it becomes the denominator in a division.

I'm not sure if the fix should be done in 'rectSizeForAspectRatio:thatFitsSize:' or in 'scaleImageForScrollViewTransitionFromBounds'