Your feedback for the existing codebase

Tasks:

• line 74: scalar parameter __zoxide_result created globally in function @zsh-eval-cache

Self-service

• I'd be willing to address this documentation request myself.

Have you read the Contributing Guidelines?

• I have read the Contributing Guidelines.

Are you familiar with the Contributor Covenant Code of Conduct?

• I have read the Contributor Covenant Code of Conduct.

Contact Details

No response

Environment

Device: apple | darwin22.0 | arm64 | Shell: /bin/zsh | -zsh | zsh-5.8.1-0-g1a490c7 Zi: 75929e8f4425761a64591d0f6c23dbb0c64261fc | zoxide v0.9.0

Reproduction steps

1. Load z-shell/zoxide:

    zi has'zoxide' wait lucid for atload="function z() { __zoxide_z \"\$@\" }" \
    z-shell/zsh-zoxide

2. Attempt to use x or z (in this case). For every directory, __zoxide_cd:cd:2: no such file or directory: <directory> is returned.

Expected behavior

x or z<SPACE><DIRECTORY> correctly hooks into zoxide.

Current behavior

For every directory, __zoxide_cd:cd:2: no such file or directory: <directory> is returned.

Code snippet

zi has'zoxide' wait lucid for atload="function z() { __zoxide_z \"\$@\" }" \
  z-shell/zsh-zoxide

Additional information

Using zsh-zoxide in isolation (no other plugins) results in the same behaviour.

It seems like zi is resetting $chpwd_functions because if I echo that once the shell is loaded, only @zi-scheduler is listed there.

if [[ ${precmd_functions[(Ie)__zoxide_hook]:-} -eq 0 ]] && [[ ${chpwd_functions[(Ie)__zoxide_hook]:-} -eq 0 ]]; then
    chpwd_functions+=(__zoxide_hook)
fi

...yet:

❯ echo $chpwd_functions
@zi-scheduler

Self-service

• I'd be willing to address this documentation request myself.

Have you read the Contributing Guidelines?

• I have read the Contributing Guidelines.

Are you familiar with the Contributor Covenant Code of Conduct?

• I have read the Contributor Covenant Code of Conduct.

Contact Details

No response

Environment

Device:pc | linux-gnu | x86_64

Reproduction steps

1. install zsh-zoxide
2. open a new terminal
...

Expected behavior

1. it wont print /home/abs3nt/.local/share/zinit/plugins/z-shell---zsh-zoxide/._zoxide/0f30bf3113e711a95459631c2d1acbf4.zsh:74: scalar parameter __zoxide_result created globally in function @zsh-eval-cache
2.
3.
4.
5.
...

Current behavior

1. it does print /home/abs3nt/.local/share/zinit/plugins/z-shell---zsh-zoxide/._zoxide/0f30bf3113e711a95459631c2d1acbf4.zsh:74: scalar parameter __zoxide_result created globally in function @zsh-eval-cache
2.
3.
4.
5.
...

Code snippet

zi ice has'zoxide'
zi light z-shell/zsh-zoxide

Additional information

.

Self-service

• I'd be willing to address this documentation request myself.

Have you read the Contributing Guidelines?

• I have read the Contributing Guidelines.

Are you familiar with the Contributor Covenant Code of Conduct?

• I have read the Contributor Covenant Code of Conduct.

Contact Details

No response

Environment

Device: pc | linux-gnu | x86_64

Reproduction steps

Start a new shell using .zshrc

Expected behavior

No error

Current behavior

I get the following error

@zsh-eval-cache:40: bad math expression: operator expected at `2'

Code snippet

Here a snippet of my .zshrc

# install zoxide
zi ice as'null' from"gh-r" sbin
zi load ajeetdsouza/zoxide
zi ice has'zoxide'
zi load z-shell/zsh-zoxide

The error is gone as soon as I comment out the last two lines of the snippet.

Additional information

N/A

Self-service

• I'd be willing to address this documentation request myself.

Have you read the Contributing Guidelines?

• I have read the Contributing Guidelines.

Are you familiar with the Contributor Covenant Code of Conduct?

• I have read the Contributor Covenant Code of Conduct.

Contact Details

[email protected]

zoxide#configuration

• https://github.com/ajeetdsouza/zoxide/blob/main/contrib/completions/_zoxide
• https://github.com/ajeetdsouza/zoxide/tree/main/man/man1

Environment

Package manager: antidote

Reproduction steps

1. Set _ZO_CMD_PREFIX to an empty string

Expected behavior

Zoxide initializes properly

Current behavior

error: The following required arguments were not provided:
  <SHELL>

Usage: zoxide init --cmd <CMD> <SHELL>

For more information try '--help'

Code snippet

 if [[ $_ZO_CMD_PREFIX =~ ^[a-zA-Z]*$ ]]; then
    # Set zoxide commands x, xi when using with Zi.
    @zsh-eval-cache zoxide init --cmd $_ZO_CMD_PREFIX zsh || {
      print "Failed to initialize zoxide, exit code: $?"
      return $?
    }

The above regex check is true when ZO_CMD_PREFIX = "" (using another package manager).

I've fixed it locally by changing the regex to detect 1 or more characters instead of 0 or more:

 if [[ $_ZO_CMD_PREFIX =~ ^[a-zA-Z]+$ ]]; then
    # Set zoxide commands x, xi when using with Zi.
    @zsh-eval-cache zoxide init --cmd $_ZO_CMD_PREFIX zsh || {
      print "Failed to initialize zoxide, exit code: $?"
      return $?
    }

Additional information

Thanks for the plugin 👍

Self-service

• I'd be willing to address this documentation request myself.

Have you read the Contributing Guidelines?

• I have read the Contributing Guidelines.

Are you familiar with the Contributor Covenant Code of Conduct?

• I have read the Contributor Covenant Code of Conduct.

Contact Details

No response