z0ph / aws-security-toolbox Goto Github PK

The reason is CONTAINER_IMAGE="aws-security-toolbox" should be CONTAINER_IMAGE="zoph/aws-security-toolbox"

Have a look at https://github.com/salesforce/policy_sentry/ ; could be a nice addition.

Cheers 🤟

Just adding this hear as a suggestion mostly AFAICT there is no reason you need git installed here other than the fact that you're cloning entire repos to install them.

However Github has a "release" feature and all the repos you're downloading utilize them. This would allow you to save installing git, just do this with curl and have a lot less work to do installing and building this image.

I also think it would make it cleaner especially because Github makes it easy to package releases for specific OS's so you could only download a .deb file if they are to make one available at some point.

Overall kudos on putting something together and trying to be useful to the community.

Current Docker Image size:

aws-security-toolbox latest 79e46d6e5909 1.54GB

• Clean cache
• Use Alpine Linux instead of Debian
• Use Packages

Nowhere in the README is this clear that you're defaulting to this region, if this project takes up any real adoption this could cause confusion for people.

My suggestion would be to default to grabbing this from a .env file and to check in a .env.example file to the repo so that people know to set a default region

Requested by users on Reddit:

• https://www.reddit.com/r/aws/comments/ei29xh/aws_security_toolbox_ast/fcr0man/?context=3