Issues with selected text with quotes in it about just-read HOT 3 CLOSED

Thanks for bringing this up. There was an error caused by the quotes because I was failing to escape them properly. Now that is fixed, but I realize that the way Chrome builds their selection function is that it returns only text, not any DOM, which leaves the selected content pretty ugly.

So, I switched up how it works so that the DOM is selected instead of just the text. It should be fixed in the next version (I'll push the changes later today).

from just-read.

Wow, thanks so much for having found a fix so quickly!

On Mon, Oct 17, 2016 at 2:32 PM, Zach Saucier [email protected]
wrote:

Thanks for bringing this up. There was an error caused by the quotes
because I was failing to escape them properly. Now that is fixed, but I
realize that the way Chrome builds their selection function is that it
returns only text, not any DOM, which leaves the selected content pretty
ugly.

So, I switched up how it works so that the DOM is selected instead of just
the text. It should be fixed in the next version (I'll push the changes
now).

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#16 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKbw4vuEK8yFgBEx59xQdrUpoWTLPO-ks5q02rKgaJpZM4KYSPx
.

from just-read.

After I uploaded the change listed above in version 1.0.6 I realized in the shower that I didn't implement it correctly. I've now fixed the bug, so version 1.0.7 should work correctly

from just-read.