Giter VIP home page Giter VIP logo

just-read's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

just-read's Issues

Change background color outside of text's body

I wish I could get the background outside the text's body in black, so I don't have too many white on my eyes. Is it possible?

(did anyone understand my request? english isn't my first language)

Inline emoji image rendering at 100% paragraph width

Just want to start by saying I absolutely love this plugin. You're doing a great job.

while reading http://fortune.com/2016/12/09/magic-leap-ceo-tech-hype/
I noticed that a small inline emoji ends up being 100% width.

Looking at it, it seems like a really hard thing to put into a general rule as they are loading a huge svg and then giving it an emoji class to shrink it to 1em.

Maybe check the computed style and if it's 1em, and surrounded by text nodes, presume it's an inline emoji?

Report broken site link

Dear @ZachSaucier,

What do you think of adding a link Report broken site to the rendered preview that forwards to Github new issue creation with the mentioning of the broken site link?

image

Share custom stylesheets to use here!

Share any stylesheets that you use and really like here!

Note: You add the stylesheets below to your copy of Just Read by right clicking the Just Read icon and clicking "Options". The options page requires creating a free account on the Just Read website. After you've created an account, paste in the CSS from your selected theme into the input field on the options page.

Issue viewing a Quora page

Hi,

First I would like to say that I use this pluggin every day and it's really helpful.

Now, the problem. I was visiting this page today and the plugin "failed" to identify the main content of the page. It took a "Top Stories" (at the bottom of the page) as main content.

Address in the bar not changing.

So there is a problem. When i click links inside the article, the url is not changing.

Here i am reading chapter 494 of a web novel:
Chapter 494

When i click next chapter, the address in the bar stays the same:
Chapter 495

And this is a problem because when i switch Just Read on again, it will again show Chapter 494, not the "correct" one.

Compatibility with another addons - hyptohesis for web notes

Hi,

First thanks so much for this great addon!

I have one question:
I am using hyptohesis addon to take note or highlight content of a webpage (e.g. when reading an articles).
I was wondering if there is any simple way to make it work with Just Read, that would be an awesome combo. Clean read & notes :)
For now, if I enable just read, it looks like the notes plugin is removed (probably some div in the html)

Thanks again!
Etienne

Style changes aren't saved after closing options panel

Repro: Update style in the options panel, style is set; close panel, style is reset

In the function closeStyleEditor() at line 699 of content_script.js, the styles are updated with the previous values rather than the updated values. Can be fixed with the following code:

    function closeStyleEditor() {
        if(!saved) {
            changeStylesheetRule(s, "body", "font-size", this.fontSize);
            changeStylesheetRule(s, ".simple-container", "max-width", this.maxWidth);
            changeStylesheetRule(s, "body", "color", this.textColor);
            changeStylesheetRule(s, "body", "background-color", this.backgroundColor);
            changeStylesheetRule(s, ".simple-author", "color", this.linkColor);
            changeStylesheetRule(s, "a[href]", "color", this.linkColor);
            changeStylesheetRule(s, "a[href]:hover", "color", this.linkHoverColor);
        }

        datGUI.destroy();
        
        closeBtn = null;
        saved = false;
    }

Can you add save as pdf function?

This extension is exactly what i need. The format for text and images is just right.

But i want to save some web pages to pdf format, i tried the chrome's save to pdf function but it still save the original web pages, so i hope you can add this function.

I know a little about css, so i think the problem may be the simple-article's height is just the screen size(100%), and the chrome's save to pdf cannot detect the 2nd page...But i don't know how to fix it...

Use styleable SVGs for the print/close icons

This would enable you to change the color of the icons in your styles - for example, when creating a dark theme.

Currently if you create a dark theme, the print icon will become invisible against the dark background.

Not Printing All Pages

Love this product, but sometimes, when printing a large number of pages it fails to load all the pages in the print window when printing to pdf.

A paid version of Just Read

Edit: There's now a premium version of Just Read! See https://justread.link/ for more information.


After thinking about the future of Just Read and some requests that have been made (#8, #18, #34), I have decided to start work on a paid version of Just Read that would potentially have the following additional features:

  • Highlighting
  • Annotations
  • Saving the article in Just Read format (including edits, highlights, and annotations) to either a server or Google Drive (researching the feasibility currently)
  • Sharing articles in a Just Read format, optionally including any highlights/annotations
  • ---Searching through articles saved--- This was too much of a technical issue to pursue right now.

Possibly also:

  • Edit-article-text ability
  • Domain-specific (or partial URL specific) Just Read styles

Question:
Are there any other features that you'd like to see in a paid version?

__

To be clear I will continue to maintain and update the free version, it just won't have any of the specific features in the above list.

Capturing incorrect elements / suggestion for a UI to remove elements

Hi Zach, thanks for the work you are doing on this. Its a great app!

There seems to be some slight problems rendering this article from the Wall Street Journal.
http://www.wsj.com/articles/companies-face-delays-getting-cash-out-of-china-1482148801

When I hit the Just Read button, there is a blank between the Title and main picture, and then after the main picture as well.
image

I tried selecting the text, but doesnt change the result.

I love the select text to read function, and works quite well in some sites. It would be good to have a UI function to easily remove elements that you don't want after you have rendered the Just Read page. Currently, I open up the developer tools to remove html elements from the Just Read page, if the Select Text to Read function captures more than necessary.

Display problems

Following our discussion on Just Read comments, I agree with you, following rechecking, that site 1 link and 3 link work almost normally. I don't know what happen the first time. And I agree with you for site 3 link that code is probably responsible.
But lot of web sites have bad code and I compared your extension with Reader, that I used with Firefox, and Clearly, that I used previously on Chrome before trying your extension.
For example, your extension doens't display the introduction paragraph (I don't know the specific term in English) of site 1 article, which displays with Clearly.
On Reader, the introduction paragraph displays but not in bold and the title of the article has disappeared ! :-)
You will find attach screen captures
– blank screen when quitting Just Read
– Liberation article display page with Just Read
– Liberation article display page with Clearly (in 2 parts)
just_read_blank_screen
liberation_article_clearly_part2
liberation_article_clearly_part1
liberation_article_just_read

And thanks for you concern about the quality of your extension.
GIlles Chauvain

Auto-run for subpages only

Why we cant active read-mode for just subpages? We should be able to write in auto-run domain list. For example:
bilimfili.com/*

Or it could be in another way. So, read mode to be activated in subpages, not for homepages.

Rendering xml code snippet strips xml tags

By visiting modelmapper.org (issue not unique to page):

xml code snippet

<dependency>
  <groupId>org.modelmapper</groupId>
  <artifactId>modelmapper</artifactId>
  <version>0.7.5</version>
</dependency>

is not rendered as it should have been:

org.modelmapper
modelmapper
0.7.5

I was expecting to see xml code snippet.

Auto-run domain list / Launching unexpectedly

Hello,

I'm using the auto-run domain list for articles websites (www.euractiv.com ; www.lemonde.fr ; www.project-syndicate.org) however as it's currently implemented it's launching unexpectdly also in url containing this character as in the rss aggregator feedly (http://feedly.com/i/subscription/feed/http://www.lemonde.fr/)

I was previously using the extension permanent readability and it was possible to fine tune more precisely the url targeted (only specific domains, not the main page ...) as you can see on the sceenshot below.

capture - permanent readability

Best Regards

Auto-enable for certain sites

Great extension! I'd love the ability to auto-activate Just Read on certain sites. A user-configurable list of domains in the options screen would probably be sufficient. Have you thought about implementing such a feature?

Other extensions don't work on the Just Read format

Other extensions that run on rendered web pages don't run on the Just Read format. A list of notable extensions that currently have this behavior include:


This is due to Just Read creating and using an <iframe> that uses an about:blank URL, which the other extensions don't usually recognize. For other extensions to work with Just read, they must include "match_about_blank": true to their manifest.json as seen in this thread and manage dynamically created elements.


With that being said, the shared versions of JR pages can support other extensions like any other webpage. See this post for more information.

Support for using Annotation extensions

It would be great to have support for annotation extensions like Diigo or Scrible.

Essentially there are extensions which help in annotating the page, me and many of my peers annotate the page and later save it. When we use Just-read we can't annotate the page. We are trying to get functionality like Evernote webclipper by using 2 extensions, one to remove clutter and one to annotate. These extensions work great separately but together they don't seem to work.

Too aggressive rendering on Google Scholar

A publication entry on Google Scholar is converted to "Unknown Date, Unknown Author" "Cite" "Ok, Done!". That's 7 words.

Example:
(https://scholar.google.com/scholar?cluster=780838853224936938&hl=en&as_sdt=0,5)
Why I wanted to use Just Read on such a page? Because I wanted to have the link to ncbi.nlm.nih.gov highlighted (and for that I was planning to use the JS found here: (http://stackoverflow.com/questions/119441/highlight-a-word-with-jquery#answer-120161)
Can I simply insert this JS in the CSS for a new JustRead style?
Thanks!

Alex

Toggling between installed themes

Hey thanks a lot for making this extension! I find myself frequently switching back and forth between dark and white background. Does it make sense and is it applicable to many people to have a button/shortcut to swap the colours of the background and the text?

Incomplete rendering and printing cut off

Using Just-Read in Chrome 56.0.2924.87 in OSX 10.11.6, on an encyclopedia article at https://plato.stanford.edu/entries/faith/, I encounter the following issues:

  1. Automatic selection leaves off the TOC and the introduction above it, and also the bibliography. Both are important to researchers! I initially thought this might be correctable through CSS, but it appears to be a JS issue.

  2. Manual selection is a workaround for the auto-select problem, but when I attempt to print the manually-selected selection (using the Just-Read print button) many pages are dropped from the bottom of the article, similar to what was reported by kiizu.

Formatter doesn't respect the <pre> tag

This comes when reading articles with embedded code blocks inside a pre tag. It doesn't respect the embedded code and uses it as normal text.

Could be a way to make an exception for this behaviour?

I love the way Just Read formats websites. It's quite useful to download pdf articles for later-reading.

This feature will improve it for sure.

Example of the current behaviour:

When some piece of code like:

leer_teclado_asincrono(t => {
  leer_fichero_asincrono(f => {
    leer_datos_asincrono(d => {
      imprime(t,f,d)
    })
  })
})

It's shown as a simple line when Just Read is ON:

leer_teclado_asincrono(t => { leer_fichero_asincrono(f => { leer_datos_asincrono(d => { imprime(t,f,d) }) }) })

Articles that don't use <p>s for content aren't auto-selected

Sometimes when pages don't use <p>s for content but use <p>s elsewhere on the page, Just Read selects the part with <p>s which is not the article content.

Example sites:


Until a fix is found for this, this error can be worked around by manually selecting the text using either user selection mode or highlight mode.

Option to change hotkey

Great plugin! It would be nice if we could change the hotkey from "Ctl-Shift-L" to anything (say "`")

Selecting meta information based on particular selectors

Hey, thank you for your great, great tool. I use it a lot for reading!

Especially on Wikipedia, which is why I thought of a suggestion. Now, on *.wikipedia.org/* the date and author are not set:

image

However, reviewing the source learns that the date is set in ID footer-info-lastmod:

image

And the author is of course Wikipedia, but could be read from ID siteSub too, so it would be translated on Wikipedia sites in other languages:
image

I could try to find a way in JS to get those values from those ID's, if you would like. Or is there another solution?

Privacy Statement

Please consider a privacy statement (for example in the readme.md) to assure people that this extension will not log any browsing activities nor forward such data to servers in the internet.

Non breaking spaces are just being deleted

It's a very straightforward problem. When there are   (it is helpful with intricate text formatting) in the article, when Just Read is switched on, they are deleted, and words are clumped together.

Example:
<p>The road was very very very&nbsp;long</p>
Becomes:
<p>The road was very very verylong</p>

Highlighter functionality

I like Just Read. It would be better if it had a highlighter function, such as the one in "Super Simple Highlighter". We use that extension to mark the text when reading, but it doesn't work when using Just Read's read mode.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.