Giter VIP home page Giter VIP logo

Comments (3)

ZachSaucier avatar ZachSaucier commented on May 14, 2024

Hello Brendan and thanks for the report!

I'm not seeing the behavior you have, this is what I see.

Are you on Windows or a Mac? Are you using the default stylesheet or one of your own? Since you know how to use dev tools, what does dev tools say the white space is from?


As for the deletion of elements, Just Read actually has a deletion mode which you can read about and enable an icon for in "Additional options". It should do exactly what you suggest.

from just-read.

brendanchua avatar brendanchua commented on May 14, 2024

Hey Zach, appreciate the speedy response. Somehow I can't seem to replicate the error when I did the screen grab. I now get the same result as what you captured. I am using PC Chrome. My apologies for that; will let you know if something similar crops up again.

And another apology - I should have seen that the deletion option first before giving my suggestion. Super nifty - well done!

On a side note, there might be a minor CSS bug.
Sometimes if I click on the 'hand' portion of the deletion toggle, the hand disappears, but the trash can stays.
image

On the other hand, I click on the trash can, it disappears, leaving the hand.
image

Sometimes, both disappear.
image

To consistently replicate the error, I have to hover on (fade in), click, hover off, hover on, click, rather than repeatedly clicking on the toggle button.
image
Seems like you created two separate icons. Was there a particular reason they were not merged?

from just-read.

ZachSaucier avatar ZachSaucier commented on May 14, 2024

Thanks again. I already knew it had some CSS issues, but you're right about the deletion aspect. I uploaded a fix and it should be in the store soon. You can update to it manually once it's on the webstore or just wait a few hours for your browser to auto-update it.

They're two separate paths within a single SVG now because I took them from 2 places and never merged them. I suppose it makes sense to merge them, though it's low priority, especially once this bug is fixed.

from just-read.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.