Giter VIP home page Giter VIP logo

osm-relatify's People

Contributors

gileri avatar muddi900 avatar starsep avatar zaczero avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

osm-relatify's Issues

Feature Wish: Correct mis-tagging of stop_position vs platform

Currently, (and correctly) both public_transit=stop_position and public_transit=platform show up, and are selectable. And stop_position is (correctly) checked that it is attached to a street included in the relation. However, if a stop_position isn't attached to any street, you just get a somewhat confusing error message. I think it should be possible for Relatify to give you the option of switching the mis-tagged stop to public_transit=platform, rather than requiring switching to another editor and spamming the Reload button till the fix shows up.

Feature Wish: Select ways more than once

Sometimes a bus travels one and the same road up, reaches the bus stop and turns around on the road and travels the same way back. For this reason, it should be possible to select routes several times in order to establish the connection correctly.

Remove unnecessary bolding of stop names with numbers in them

Hello,

I've been using Relatify to add and update bus routes around Kraków, Poland and so far it's been really great.
While updating one of the bus routes I found out that when there are numbers in the stop name, Relatify will bold the numbers as if it was a stop number:

image

I don't think that's necessary, the tool should bold just the stop number.

Ignore oneway roads that can't be entered

Currently OSM Relatify suggests to add roads that buses cannot enter because they are one-way. If these roads are not displayed, it would save a lot of time and clicks for the mappers.

image

Feature Wish: Show bus stop ref more easily

Currently the ref value of a bus stop is only visible after clicking Inspect and waiting for OSM to load. I use that value to make sure I'm referring to the right stop, when there are multiple ones with similar names nearby. It would be nice if that value was visible in the menu that comes up when you right click on the stop (that currently just has the Inspect link) (or even added to the popup).

Allow loading a route with no ways as members or at least fail gracefully

I created a new route to try and fill it out with Relatify, but upon attempting to load it, I got a generic 500 Internal server error message. I assumed it was because I had no ways as members of the route, so I added a way and then it loaded fine. If it's not intended to load such routes, it would at least be great to have a corresponding error message.

Add ref and name to changeset description

The description of the changeset could be extended to include the values of the 'ref' and 'name' tags from the updated relation. Such a description would make it easier to verify which bus route has been updated.

Hide `bus=no` stops

Currently when a stop is tagged with bus=no, it's still shown in Relatify. It may sound like a troll tag but it is used in situation where other vehicles (like trolleybuses) have their own road or when trolleybuses serve all stops while buses run express services.

image

The sign that is closer to the camera is the bus stop, the sign in the back is for the trolleybus.
image

Oneways

The program does not take into account conditionally one-way streets, e.g. if you specify "oneway=yes" and "oneway:bus=no", it will still consider the street as one-way. An example of this can be seen for relation 6959984.

No "Finish editing" button

I tried a route to edit, but I don't save/upload, because there is no blue Finish editing button.
What can I do, or what I need to upload my edits?

Feature Wish: set "Start" and "End" icon where the stop_position is

Here https://relatify.monicz.dev/?relation=7853739&load=1#map=19/47.868148/11.474037
the "S" is placed on the middle node of the way, the stop_position is on the first node https://www.openstreetmap.org/way/168730182

  • "S" should also be the first node of the journey (first or last node of the first way, depending on it's direction as an OSM vector)
  • "E" should also be the last node of the journey (last or first node of the last way, depending on it's direction as an OSM vector)

Marking a stop_position as "S" or "E" might result in the need to split the relevant way to achieve the things said above.

Documentation or wiki or explanations?

Hello.
Once I load a bus relation I understand the meaning of the marching path.. That's the selection of the ways to be included in the relation.
But what is the meaning of selecting bus stops on the map and on a big list of bus stops?

Perhaps you could create some documentation for this tool?

Thank you.

Automatically changes stop_position to a wrong node without notification

I fixed some issues on a bus route and Relatify exchanged the node of a stop_position to another one.
The fix I did is not related to "Tattenkofen".

https://relatify.monicz.dev/?relation=7853739&load=1#map=19/47.861958/11.516756

Stop "Tattenkofen" was properly mapped, stop_position was on the correct node (the northern one)

Relatify exchanged the northern stop_position by the southern one (belongs to opposite direction) because that node is closer to the platform node?

BTW: "stop_position" is usually placed where the front-door of the bus is, "platform" is usually placed where the pole (with timetable,...) is. In "Tattenkofen" this looks strange, but that's the way it is.

Pro: I like that feature where Relatiy shows stop_position and platform as a single icon which allows easy adding of a stop to a route.

Feature request: `hail_and_ride` route sections

In some places there are bus routes that allow the bus to stop to pick up or drop off passengers at any point along certain roads. OSM support for this was not part of the original proposal for PTv2, but was approved later.

This role is in use for PTv2 routes in many places around the world especially for rural or suburban portions of routes.

Would it be possible to add support for member ways with the hail_and_ride role in Relatify?

From a user perspective I think Ralatify would need:

  • a different colour for hail_and_ride portions of a route to make them identifiable on the route (dark green like the stop icons?)
  • hail_and_ride sections to satisfy the "minimum number of stops" validator
  • the ability to add or remove the hail_and_ride role on ways already in the relation (probably add to right click menu along with start and finish)
  • the ability to say that a newly added way should be added as hail_and_ride (possibly by holding a key on the keyboard when you click on it).

If this is not something feasible in the short term would it be possible to have it on the road map for future additions?

Platforms and stops gets removed from existing relation

I have tried out the tool on a couple of routes, but either platforms or stops seem to get removed from the relation after uploading the changeset to OSM. I also can't click on both platform and stop_position for the same bus stop, it seems to be either or. This unfortunately makes the tool unusable on routes that are somewhat mapped already, but just need a bit of correction of the ways. The relations in question are 2919652 (fixed by me afterwards, but you can see all the platforms/stop_positions that relatify removed in the history) and 2726495 (not fixed by me afterwards).
Am I doing something wrong or is there a bug in the tool? I compared two bus stops that were tagged identically, and one of them (11151650) somehow got both platform and stop_position included in the relation, while the other (11165954) only got the stop_position included.

Relatify doesn't show the first stop of roundtrips in the preview panel

Relation id: 16275185

When you edit the route (by removing a stop) and go to the preview panel you will see that the first stop is "Циркова площадка" and the last stop is "Гаров площад". After uploading and checking the relation you will see that the first and last stop is "Гаров площад".

Relatify can't handle conditional bus restrictions.

Example relations 12381963 and 2632957.
They go over road segments which have the following real world restriction:
image
In OSM these segments are tagged as

access=no
bus=no
bus:conditional=yes @ (operator=Metropolitan Transportation Authority)
emergency=designated

Unfortunately, relatify doesn't doesn't show such ways at all.
image

Support public_transport=station

It seems like only public_transport=platform can be selected, not public_transport=station. This makes it harder to include terminal stops.

Fails spliting roundabout and adapting **all** affected route relations

I did a fix on a bus route and (according to Relatify) there was a need to split a roundabout into segments.

https://relatify.monicz.dev/?relation=9885680&load=1#map=19/47.756718/11.559851

Relatify failed fixing (removing unused segments, resorting segments) all affected other route relations - there are tons of them, this is a central roundabout used by many bus routes (load this into JOSM and you'll see how many).

BTW: many mappers consider having an un-split roundabout (single way) in route relations as a valid mapping habit.

Suggestion: do not split single-way roundabouts, that's a challenging task. iD and StreetComplete also fail on this and "create" broken route relations.

Bug: "Some stops are not reached" but "Show me" button does nothing

I'm working on a route (relation #16411141) and after adding all of the stops and ways and selecting the start and end ways, I'm left with a "Some stops are not reached" error, but I can't find out what stops it thinks are broken because clicking the "Show me" button does not seem to have any effect. There are no obviously related errors in the console, either.

I'm using Firefox on a Macbook Air.

Allow working with trolleybus routes

I noticed when trying to load a trolleybus route that it returned that it wasn't a valid bus route. I am not certain, but I think there should be no difference between bus and trolleybus route processing - they do exactly the same thing. I should mention that I realize this is on the planned list, but this seems like a very low-hanging fruit, considering it's (probably) just another route value and can otherwise be treated the same.

Feature Wish: Copy a route

It would be great to have a way in the app (I presume JOSM can do it already) to duplicate an existing route so it could be modified, as there are often very similar routes (i.e. a few stops skipped on weekends) that are painful to create in the app now.

Hint: if splitting roundabouts ...

I get an error message if a roundabout is not split and completely included in a relation.
One can argue pro/con related to this. PTNA has an analysis option allowing this.

But: if Relatify splits the roundabout when clicking on the superfluous ways: take care that other route relations are not damaged and must be manipulated in the same way. This is a challenging task, iD often fails here.

If a roundabout is split into segments, only used segments must be in a relation.

stuck at "downloading data"

For some reason, sometimes I'm stuck at "downloading data" especially when the way that is added is long. Once in that state, nothing happens anymore.

Browser: Firefox 102.13.0esr

Allow temporary route hiding to see streetnames

The current tool supports OSM carto and OSM de tiles for the background layer. In both cases the label for the road is over the road. When relatify draws a path over the top of the roads it makes it impossible to read the road names with these styles. This might not be too bad for new relations but it makes it very difficult to check the names of the streets you are editing.

The use of something like the Thunderforest Transport layer without existing routes would be ideal as it offsets the street names, but probably has ongoing cost implications.

Would it be possible to add a transparency slider or a button to temporarily hide the ways and potential roads to be added and make it possible to read the streetnames?

Relatify breaks a correctly and completely mapped round-trip route relation

https://relatify.monicz.dev/?relation=3548588&load=1

and save and see the OSC file in JOSM

It is correctly and completely mapped as of 2023-06-30 00:15 AM

It corresponds to this route given as GTFS https://ptna.openstreetmap.de/gtfs/DE/single-trip.php?feed=DE-BY-MVG&release_date=&trip_id=4.T0.3-58-G-013-1.6.R

  • deletes the first stop and makes the second one the a stop_entry_only
  • changes role stop to stop_exit_only on the last stop
  • deletes many of the public_transport=platform from the relation
  • breaks the round-trip into a start and stop (with respect to the stops)
  • keeps the round-trip based on member ways

Invalid "some routes are not used at all" messages

Created relation 16017925 to test the software.

Added ways 1146049452 and 1146049452 to test the software.

Loaded the relation into the software and then tried to add further ways to the relation. In all cases the message "some routes are not used at all" came up. It did not matter whether I started with way 1146049451 or way 1076459329, the same invalid message resulted in both cases.

image

image

image

The software is clearly not detecting the direction of the route properly in this scenario. The number of bus stops message is not relevant because fewer than two had been added at that point anyway so it is expected that would be displayed.

Feature wish: Add all ways until next intersection/bus stop

When adding ways to a bus route, you currently have to add every segment of a highway manually. Since there is no way for a bus route to end before it encounters an intersection or a bus stop, it would make sense and speed up editing by adding all ways until the next intersection/bus stop automatically. If the next segment goes beyond an intersection or a bus stop, it should be split in the editor (but not in the database until uploading) to facilitate turning off the current highway.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.