zakhar-petrov / rocketchat-youtrack-linker Goto Github PK

There are several ways to install app

• Use UI to upload zip with release from github
• Use Node.js and rc-apps
• Marketpalce ?

It can be useful for messages from SCM webhooks with commit messages (messages can contain meta with issue reference).

Default issue pattern links following text lines:

• ACM-123ABC-123
• 0ABC-123
• ABC-123A

Seems, it should ignore such lines

Sugession for regex pattern: (^|[^a-zA-Z0-9])([a-zA-Z]+-[0-9]+)([^a-zA-Z0-9]|$) instead of [a-zA-Z]+-[0-9]+

Changing property from default value has no effect, there are still 25 iterations

Hello,

I'm not able to make this app works when I edit a message while I don't have any issue if I directly write a message with the pattern.

As a example:

1. Working scenario :
   1.1 write a message with a pattern
   Please see YT-5757
   1.2 It works, pattern will be substitute by HTTP link (according to the app configuration)

2. Not working :
   2.1 write a message but forgot the pattern
   Please see
   2.2 edit this message and add YT-5757
   Please see YT-5757
   2.3 This will result in a message with text only, pattern will not by substitute.

Any chance to make it work with messages editing ?

Thanks.

Rocket.Chat Marketplace Team:

We have reviewed your App and determined something needs to change about it. Here is the reviewer's notes: While we understand the usage of the uncontrolled while loop, we would ask that for the sake of servers you go with a more controlled condition of which the while operates upon such as the count of matches or some other way which is controlled and doesn't hold up the process/thread as much. If you feel that this approach is still the best route to go, please contact us and we can discuss it.

Version: v1.0.3