Comments (5)
What if someone wants to use Zappr only as a suggestion, but not as a
requirement? Would a button in Zappr "protect master" also be good?
On 11 March 2016 at 09:55, Maximilian Fellner [email protected]
wrote:
Use the protected branches API
https://developer.github.com/changes/2015-11-11-protected-branches-api/
to automatically protect the master branch when approvals are enabled for a
repository.โ
Reply to this email directly or view it on GitHub
#86.
undefined = () => {}
__
.ยด o)=-
/.-.'
// |
|| |' Nikolaus Piccolotto
,:)/ engineer.js
from zappr.
What if someone wants to use Zappr only as a suggestion, but not as a
requirement? Would a button in Zappr "protect master" also be good?
I wouldn't invent something that Github already provides.
from zappr.
@whiskeysierra Valid point :)
I just think doing this automatically might be unexpected (as Travis doesn't do it either) and people tend not to read textual notes.
from zappr.
There were recently some changes to the Protected Branches API announced: https://developer.github.com/changes/2016-06-27-protected-branches-api-update
from zappr.
I changed my mind. We should just make every check a required status check automatically, because it makes sense for most of them anyways.
from zappr.
Related Issues (20)
- readthedocs header hides parts of documentation HOT 3
- Making Zappr Github Marketplace ready. HOT 2
- add 503 API errors to trouble shooting section
- Accept webhook url as a config parameter HOT 4
- OneOf Labels Check HOT 5
- Support Label based approver group conditions
- Mandate 'contains-issue-number' in PR's body HOT 1
- Zappr fails on (?:(?i)AND)(?:-|\s)\d+ commit msg pattern HOT 2
- Quiz about Authorization Callback URL HOT 3
- Zappr incorrectly reports a check was enabled by a user
- Approval/veto regexes only work for start of comment HOT 1
- Add prettier to the project.
- Ignore "pull request tasks check" for specified checkboxes
- User-defined regex patterns for specification body options `contains-issue-number` and `contains-url`
- Effective config `specification.title.minimum-length` has property `enablead`
- Incorrectly reported failed check name 'contains-issue-number'
- "Update this Branch" should not require approvals again
- Zappr does not response
- Unexpected rejection of the PR title: "PR's title is too short (8/8)"
- Builds are failing since December, 6th
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zappr.