zalando / zappr Goto Github PK
View Code? Open in Web Editor NEWAn agent that enforces guidelines for your GitHub repositories
Home Page: https://zappr.opensource.zalan.do
License: Other
An agent that enforces guidelines for your GitHub repositories
Home Page: https://zappr.opensource.zalan.do
License: Other
For certain API operations that are automatically performed by the web service in response to a webhook we need a valid OAUTH token.
The webhook events and resulting operations are always associated with a check. So it would make sense to save the current user's token in each check that gets turned on.
Has this something to do with being a collaborator?
Currently we're just using default postgres database out of comfort, but in anticipation of #44, where we require yet another schema, it would be beneficial to switch to a dedicated zappr database as long as it's easy.
Use koa-generic-session with koa-redis or some other Store implementation instead of the default MemoryStore for session storage.
When building the server npm run build-server
there is an error (but the build completes nominally):
ERROR in ./server/service/EncryptionService.js
Module parse failed: /Users/mfellner/Code/Github/zalando/zappr/node_modules/babel-loader/index.js?{"presets":["node5","stage-3"]}!/Users/mfellner/Code/Github/zalando/zappr/server/service/EncryptionService.js Line 28: Unexpected token ;
You may need an appropriate loader to handle this file type.
|
| class EncryptionService {
| static instance;
|
| static create() {
@ ./server/model/Check.js 25:25-64
The semicolon after instance
gets automatically injected, even if it is removed (failing the eslint check).
Suggestion: refactor the singleton pattern (which is strange anyway) to simply leverage the Node module.
When a PR in my project is open for longer than n
time units, Zappr should send a reminder email to a configured email address. If no action is taken by the receiver(s), Zappr should close the PR after m
time units. An example for such action could be a button in the email "keep PR open".
because regex.test(string)
does not return a number and is thus always not equal to -1
.
Define the Value Proposition Canvas for Zappr.
Define the following aspects:
Google doc: https://docs.google.com/document/d/1-4PXtNApl6OnF5fzdOdLOAI7y2e3q1mB4WFXWR_mYz8
For instance
https://docs.google.com/document/d/1ZFAQMOfT7iB3xP_-zBid_qSQVRAa8HsF9GZqJUR7Eb8
Create a Google survey about Github, Stash and general workflow habits.
Compile the following resources:
Main obstacle: Tickets that do not live in same Github installation. Not the common case, but might happen.
Should be relatively easy and we identified this as a nice ticketing/scm integration feature.
It should be possible to give Zappr only a minimal set of permissions initally and then upgrade.
User
(first* db migration!)X-OAuth-Scopes
response header.In worst case we would have to revoke all access tokens we got via Github web UI and delete them from our database.
Think of a way to restore functionality with minimal user effort (ie ideally not more than logging in).
Create and compare user journeys about their development workflows.
Workflow & Interviews: https://docs.google.com/document/d/16jHNJrsM1X0mMkTbizgRZbsxkr7MZrvJMyWTLQ8pS3M/edit
Most active teams on Stash and possible contacts:
We should be able to:
Use the protected branches API to automatically protect the master branch when approvals are enabled for a repository.
Test "should render the selected repository" sometimes fails:
Maybe with KMS so we don't have to take care of the encryption key.
Github just announced support for reactions.
I did not see any API support yet, but that could be a great interface for approvals.
Figure out a way for people to define state transitions for issues via labels. The main obstacle here is the feedback loop: One adds a label, representing an invalid transition, and then what? Just remove it again? If so, how to inform user about invalid transition? Email?
It's just a sign-in button now without any hint what's behind. Before go-live we should put some love into that.
Create a complete documentation for the contributors and developers of Zappr.
Tasks
For different branches on enabled repos, send a daily (configurable) commit summary from other people to encourage code review prior to PR.
Main question is how to organise it as its possibly lots of information.
Some people I've talked to say that approving releases and/or deployments is very important to them. How could we address this?
What we need to understand
Notes
When updating repositories from Github the whole list is replaced with a giant spinner. We can make this more subtle, I guess. Also I think "load all" does not really transport what it does / is slightly confusing, so we should stick to the wording that Travis uses: sync
. And thinking about it, is there a specific reason why one cannot work with the UI during a sync?
Improve logging to provide the most useful information in order to trace all transactions:
Also see https://www.npmjs.com/package/debug
I tried to enable zappr
on delivero/gitworkflowsamples, which then resulted in an internal server error. See attached screenshot.
Currently a repository can belong only to a single user. This is incompatible with teams and organisations.
I thought we fixed this. :(
Reproducable by:
/
and filter list by zappr
zalando/zappr
Search field is now empty.
Add a secret to a check and in the hook validate the hash of the payload.
Approval.execute
actually does stuffWhen using the auto completion to create the :+1:
, Github appends a single space to the emoji. This extra white space prevents the Zappr regex from matching.
Create a complete documentation for the users of Zappr.
Tasks
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.