zapnap / bitbank Goto Github PK

Would be a nice feature, to check the given bitcoin address if its valid. So there can't be wrong transaction (but maybe bitcoind does it on its own?)

Please use the money gem! Floats are very bad for currencies... See following example:

irb

1.0 - 0.9
=> 0.09999999999999998

You should require the money gem, define your own currency (bitcoin, 8 decimals after comma (sry for my bad english)) and parse every amount of money with an money object.

What do you think of this?

What version of rails are you using where you have activesupport >= 3.0.7 and i18n >= 0.6.0 !?!? Bundler tells me that rails ~> 3.0.7 requires i18n 0.5.0

If I use rails 3.1.0.rc4 to get i18n 0.6.0 then bundler complains that bitbank needs that older version of activesupport. I don't see how there could be a way to override rails to use a newer version of i18n ...

Please use the money gem! Floats are very bad for currencies... See following example:

irb

1.0 - 0.9
=> 0.09999999999999998

You should require the money gem, define your own currency (bitcoin, 8 decimals after comma (sry for my bad english)) and parse every amount of money with an money object.

What do you think of this?