Comments (2)
Thanks! I've made it much more simple now.
Tested with id3v2 --USLT asd a.mp3
. @Martchus
from qmplay2.
With this patch it builds but I have no test case:
diff --git a/src/modules/FFmpeg/FormatContext.cpp b/src/modules/FFmpeg/FormatContext.cpp
index a5c45496..8e14b5d8 100644
--- a/src/modules/FFmpeg/FormatContext.cpp
+++ b/src/modules/FFmpeg/FormatContext.cpp
@@ -363,7 +363,11 @@ QList<QMPlay2Tag> FormatContext::tags() const
else
{
// check for all fields starting with "lyrics-" because libavformat's ID3v2 code adds lyric fields like that
+#if LIBAVUTIL_VERSION_MAJOR >= 58
for (const AVDictionaryEntry *avTag = av_dict_iterate(dict, nullptr); avTag; avTag = av_dict_iterate(dict, avTag))
+#else
+ for (const AVDictionaryEntry *avTag = av_dict_get(dict, "", nullptr, AV_DICT_IGNORE_SUFFIX); avTag; avTag = av_dict_get(dict, "", avTag, AV_DICT_IGNORE_SUFFIX))
+#endif
{
if (!std::strncmp(avTag->key, "lyrics-", sizeof("lyrics-")) && !(value = getTag(avTag)).isEmpty())
{
from qmplay2.
Related Issues (20)
- QMPlay2 can not open video files named in Arabic HOT 10
- Impossible to play videos from https://my.mail.ru/video HOT 13
- Difference between the "video" widget and the shortcut "o" which disable video HOT 2
- yt-dlp failing HOT 2
- Audio stuttering when playing any video HOT 15
- "Vulkan" not active despite all controllers installed (Ryzen + Radeon) HOT 14
- Youtube subtitle encoding problem
- Full dark mode theme even in the top bar HOT 2
- QMPlay2 crashed HOT 6
- Start and Stop recordig video
- Changing volume control while a video is playing crashes app HOT 19
- runtime selection of YT video stream HOT 4
- Radio Station Icons Missing HOT 1
- How can I prevent the channels from skipping when the channel is frozen? HOT 7
- [macOS] `QMPlay2` 16.04.23 fails to build on 10.6: `OpenGL2Common.hpp: error: 'GLActiveTexture' does not name a type` etc. HOT 26
- MediaBrowser results not playable HOT 1
- YT video doesn't open, downloads with yt_dlp HOT 21
- Issues for TV Arib Subtitle HOT 4
- Establish compatibility with taglib 2.0 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from qmplay2.