Giter VIP home page Giter VIP logo

Comments (2)

zaps166 avatar zaps166 commented on June 2, 2024 1

Thanks! I've made it much more simple now.

Tested with id3v2 --USLT asd a.mp3. @Martchus

from qmplay2.

RJVB avatar RJVB commented on June 2, 2024

With this patch it builds but I have no test case:

diff --git a/src/modules/FFmpeg/FormatContext.cpp b/src/modules/FFmpeg/FormatContext.cpp
index a5c45496..8e14b5d8 100644
--- a/src/modules/FFmpeg/FormatContext.cpp
+++ b/src/modules/FFmpeg/FormatContext.cpp
@@ -363,7 +363,11 @@ QList<QMPlay2Tag> FormatContext::tags() const
         else
         {
             // check for all fields starting with "lyrics-" because libavformat's ID3v2 code adds lyric fields like that
+#if LIBAVUTIL_VERSION_MAJOR >= 58
             for (const AVDictionaryEntry *avTag = av_dict_iterate(dict, nullptr); avTag; avTag = av_dict_iterate(dict, avTag))
+#else
+            for (const AVDictionaryEntry *avTag = av_dict_get(dict, "", nullptr, AV_DICT_IGNORE_SUFFIX); avTag; avTag = av_dict_get(dict, "", avTag, AV_DICT_IGNORE_SUFFIX))
+#endif
             {
                 if (!std::strncmp(avTag->key, "lyrics-", sizeof("lyrics-")) && !(value = getTag(avTag)).isEmpty())
                 {

from qmplay2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.