YT video doesn't open, downloads with yt_dlp about qmplay2 HOT 21 OPEN

RJVB commented on June 2, 2024

YT video doesn't open, downloads with yt_dlp

from qmplay2.

Comments (21)

zaps166 commented on June 2, 2024

This video plays at 1080p 30 FPS H.264.
What should I set to fail?

from qmplay2.

RJVB commented on June 2, 2024

This video plays at 1080p 30 FPS H.264.

It also plays at 720p, H264, indeed.

What should I set to fail?

The thing is that the settings for codec and quality are both "preferred". I thought that your algorithm already falls back to H264 if VP9 isn't available but maybe that's only the case when there are no VP9 streams at all? In this case I'd argue that (in absence of counter instructions) precedence should be given to the user-selected preferred maximum resolution which I think more likely to correspond to hardware limitations than the preferred codec. So, if a video has streams in the preferred high-quality codec but only in a superior resolution - fall back to a lower-quality codec if a stream exists with that codec and the preferred resolution - find the nearest higher resolution in the preferred codec otherwise. But I realise that users who have HW-accelerated VP9 decoding might not agree with that priority and at some point we'll probably also have to deal with prioritising the 3 supported codecs. An alternative for this situation where QMPlay2 can't make a choice would be to pop up a list with all existing codec/resolution pairs and let the user pick one. It isn't very elegant to let the user believe something is wrong with the video (or that YT have started cracking down on our "stealing" their ad income) while really the problem is just that the automatic selection of the most appropriate video stream fails.

from qmplay2.

zaps166 commented on June 2, 2024

Please check this function:

QMPlay2/src/modules/Extensions/YouTube.cpp

Line 791 in be34a21

QVector<int> qualityPresets[PresetCount];

Here are all supported formats within presets and primary codec.

from qmplay2.

RJVB commented on June 2, 2024

src/modules/Extensions/YouTube.cpp#L791

I suppose I should look at the block starting at line 802, to know in what order you handle format fallbacks?

Here's the format list as I get it today, which I have trouble reading btw (where's the 1080p VP9 stream I downloaded yesterday, for instance) :

> yt_dlp -F "https://www.youtube.com/watch?v=fbCK297tylw"
[youtube] Extracting URL: https://www.youtube.com/watch?v=fbCK297tylw
[youtube] fbCK297tylw: Downloading webpage
[youtube] fbCK297tylw: Downloading ios player API JSON
[youtube] fbCK297tylw: Downloading android player API JSON
[youtube] fbCK297tylw: Downloading m3u8 information
[info] Available formats for fbCK297tylw:
ID  EXT   RESOLUTION FPS CH │   FILESIZE   TBR PROTO │ VCODEC          VBR ACODEC      ABR ASR MORE INFO
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
sb3 mhtml 48x27        0    │                  mhtml │ images                                  storyboard
sb2 mhtml 80x45        0    │                  mhtml │ images                                  storyboard
sb1 mhtml 160x90       0    │                  mhtml │ images                                  storyboard
sb0 mhtml 320x180      0    │                  mhtml │ images                                  storyboard
233 mp4   audio only        │                  m3u8  │ audio only          unknown             [en] Default
234 mp4   audio only        │                  m3u8  │ audio only          unknown             [en] Default
139 m4a   audio only      2 │   29.60MiB   49k https │ audio only          mp4a.40.5   49k 22k [en] low, m4a_dash
140 m4a   audio only      2 │   78.56MiB  129k https │ audio only          mp4a.40.2  129k 44k [en] medium, m4a_dash
251 webm  audio only      2 │   69.89MiB  115k https │ audio only          opus       115k 48k [en] medium, webm_dash
269 mp4   256x144     30    │ ~106.80MiB  172k m3u8  │ avc1.4D400C    172k video only
160 mp4   256x144     30    │   35.69MiB   59k https │ avc1.4D400C     59k video only          144p, mp4_dash
230 mp4   640x360     30    │ ~408.27MiB  657k m3u8  │ avc1.4D401E    657k video only
134 mp4   640x360     30    │  157.59MiB  260k https │ avc1.4D401E    260k video only          360p, mp4_dash
18  mp4   640x360     30  2 │  215.05MiB  354k https │ avc1.42001E         mp4a.40.2       44k [en] 360p
605 mp4   640x360     30    │ ~328.56MiB  529k m3u8  │ vp09.00.21.08  529k video only
22  mp4   1280x720    30  2 │ ≈681.93MiB 1098k https │ avc1.64001F         mp4a.40.2       44k [en] 720p
232 mp4   1280x720    30    │ ~  1.19GiB 1967k m3u8  │ avc1.64001F   1967k video only
136 mp4   1280x720    30    │  588.10MiB  969k https │ avc1.64001F    969k video only          720p, mp4_dash
270 mp4   1920x1080   30    │ ~  2.12GiB 3498k m3u8  │ avc1.640028   3498k video only
137 mp4   1920x1080   30    │    1.03GiB 1743k https │ avc1.640028   1743k video only          1080p, mp4_dash

I didn't restart QMPlay2 after checking your latest commit but today the video starts just fine, giving me 720p30 H264 instead of the preferred VP9 720p60. I was going to ask if you already changed something but I shouldn't be seeing the effects of that until I relaunch the app (unless you have a clever module reloading algorithm?). Is it possible YT changed something?

from qmplay2.

YT video doesn't open, downloads with yt_dlp about qmplay2 HOT 21 OPEN

Comments (21)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent