The fractioncalculator from zaryabmakram

fractioncalculator's People

Contributors

Watchers

fractioncalculator's Issues

Hey!

Hey just wondering if I could use some of your code on a project I am doing, I'll give credit to the repo because its pretty good

equals(), gcd() and toLowestTerms() seem not to work for me?

See title...

When testing two fractions that are the same when taken down to lowest terms (I am doing 8/4 and 4/2), I still get a false result when using my equals method

public static int gcd(int num, int den){
    if (den == 0){
        return num;
    }
    return gcd(den, num % den);
    
}

public void toLowestTerms(){
int greatestCD = gcd(this.numerator, this.denominator);

    this.numerator /= greatestCD;
    this.denominator /= greatestCD;

    if (this.denominator < 0){
        this.numerator *= -1;
        this.denominator *= -1;
    }//end if

}//end toLowestTerms

public boolean equals(Object other){
if (other instanceof Fraction){
Fraction comparedFraction = (Fraction)other;
comparedFraction.toLowestTerms();

        Fraction thisFraction = new Fraction(this.numerator, this.denominator);
        comparedFraction.toLowestTerms();

        if(thisFraction.numerator == comparedFraction.numerator && thisFraction.denominator == comparedFraction.denominator){
            return true;
        }
        else {
            return false;
        }
    }//end if other is a fraction object
    else{
        throw new InputMismatchException();
    }
}

////////////////////////

Would appreciate any feedback if possible

Recommend Projects